Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 10829281: Make ChromeOS imply enable_hidpi (Closed)

Created:
8 years, 4 months ago by pkotwicz
Modified:
8 years, 4 months ago
Reviewers:
flackr
CC:
chromium-reviews
Visibility:
Public.

Description

Make ChromeOS imply enable_hidpi Bug=None Test=Compile ChromeOS without enable_hidpi GYP_DEFINE. R=flackr TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151160

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
pkotwicz
Rob can you please take a quick look?
8 years, 4 months ago (2012-08-10 18:18:31 UTC) #1
flackr
LGTM
8 years, 4 months ago (2012-08-10 18:19:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10829281/2001
8 years, 4 months ago (2012-08-10 18:50:07 UTC) #3
commit-bot: I haz the power
Presubmit check for 10829281-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-10 18:50:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10829281/2001
8 years, 4 months ago (2012-08-10 22:32:59 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-11 00:04:30 UTC) #6
Change committed as 151160

Powered by Google App Engine
This is Rietveld 408576698