Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc

Issue 10829276: Get web application list using Drive V2 API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nits. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc
diff --git a/chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc b/chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc
index c9413b99475da0afbf240e0cf047ec868e4ce826..4c89d7c1d94fdbb503e999bb57e3d065e19b5d23 100644
--- a/chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc
+++ b/chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc
@@ -17,6 +17,7 @@
#include "base/threading/sequenced_worker_pool.h"
#include "base/values.h"
#include "chrome/browser/chromeos/cros/cros_library.h"
+#include "chrome/browser/chromeos/gdata/drive_api_parser.h"
#include "chrome/browser/chromeos/gdata/drive_webapps_registry.h"
#include "chrome/browser/chromeos/gdata/gdata.pb.h"
#include "chrome/browser/chromeos/gdata/gdata_file_system.h"
@@ -192,7 +193,8 @@ class MockDriveWebAppsRegistry : public DriveWebAppsRegistryInterface {
ScopedVector<DriveWebAppInfo>* apps));
MOCK_METHOD1(GetExtensionsForWebStoreApp,
std::set<std::string>(const std::string& web_store_id));
- MOCK_METHOD1(UpdateFromFeed, void(AccountMetadataFeed* metadata));
+ MOCK_METHOD1(UpdateFromFeed, void(const AccountMetadataFeed& metadata));
+ MOCK_METHOD1(UpdateFromApplicationList, void(const AppList& applist));
};
class GDataFileSystemTest : public testing::Test {
@@ -886,7 +888,7 @@ TEST_F(GDataFileSystemTest, DuplicatedAsyncInitialization) {
EXPECT_CALL(*mock_doc_service_,
GetDocuments(Eq(GURL()), _, _, _, _)).Times(1);
- EXPECT_CALL(*mock_webapps_registry_, UpdateFromFeed(NotNull())).Times(1);
+ EXPECT_CALL(*mock_webapps_registry_, UpdateFromFeed(_)).Times(1);
file_system_->GetEntryInfoByPath(
FilePath(FILE_PATH_LITERAL("drive")), callback);
@@ -1223,7 +1225,7 @@ TEST_F(GDataFileSystemTest, CachedFeadLoadingThenServerFeedLoading) {
mock_doc_service_->set_account_metadata(
LoadJSONFile("account_metadata.json"));
EXPECT_CALL(*mock_doc_service_, GetAccountMetadata(_)).Times(1);
- EXPECT_CALL(*mock_webapps_registry_, UpdateFromFeed(NotNull())).Times(1);
+ EXPECT_CALL(*mock_webapps_registry_, UpdateFromFeed(_)).Times(1);
EXPECT_CALL(*mock_doc_service_, GetDocuments(_, _, _, _, _)).Times(0);
// Kicks loading of cached file system and query for server update.
@@ -1235,7 +1237,7 @@ TEST_F(GDataFileSystemTest, CachedFeadLoadingThenServerFeedLoading) {
mock_doc_service_->set_account_metadata(
LoadJSONFile("account_metadata.json"));
EXPECT_CALL(*mock_doc_service_, GetAccountMetadata(_)).Times(1);
- EXPECT_CALL(*mock_webapps_registry_, UpdateFromFeed(NotNull())).Times(1);
+ EXPECT_CALL(*mock_webapps_registry_, UpdateFromFeed(_)).Times(1);
file_system_->CheckForUpdates();
test_util::RunBlockingPoolTask();
@@ -2478,7 +2480,7 @@ TEST_F(GDataFileSystemTest, ContentSearchWithNewEntry) {
EXPECT_CALL(*mock_doc_service_, GetAccountMetadata(_)).Times(1);
EXPECT_CALL(*mock_doc_service_, GetDocuments(Eq(GURL()), _, "", _, _))
.Times(1);
- EXPECT_CALL(*mock_webapps_registry_, UpdateFromFeed(NotNull())).Times(1);
+ EXPECT_CALL(*mock_webapps_registry_, UpdateFromFeed(_)).Times(1);
SearchCallback callback = base::Bind(&DriveSearchCallback,
&message_loop_, kExpectedResults, ARRAYSIZE_UNSAFE(kExpectedResults));

Powered by Google App Engine
This is Rietveld 408576698