Add new 1X and 2X assets in chrome/app/theme in a new directory structure.

Add new 1X and 2X assets in chrome/app/theme in a new directory structure.

BUG=137351
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151296

[oshima, 2012-08-10 04:14:46]

Could you please ask UX team (sgabriel?) to fix the filename for these
resources?
We agree no to use abbreviations.

chrome/app/theme/default_100_percent/common/ev_bubble_{c|l|r}.png   (-> center,
right, left)
chrome/app/theme/default_100_percent/common/infobarbutton_{c|l|r|tl|tr|bl|br}_xxxx.png
chrome/app/theme/default_100_percent/common/infobarbutton_{c|l|r}_n.png  (n ->
normal)
chrome/app/theme/default_100_percent/common/omnibox_{c|l|r}.png
chrome/app/theme/default_200_percent/common/ev_bubble_{c|l|r}.png

I also wonder if we can rename this

chrome/app/theme/default_100_percent/common/help_16.png

to just help_menu.png. That's consistent with the IDR name and makes more sense.

[oshima, 2012-08-10 04:15:49]

There is another one.

keyword_search_bubble_{c|l|r}.png

On 2012/08/10 04:14:46, oshima wrote:
> Could you please ask UX team (sgabriel?) to fix the filename for these
> resources?
> We agree no to use abbreviations.
> 
> chrome/app/theme/default_100_percent/common/ev_bubble_{c|l|r}.png   (->
center,
> right, left)
>
chrome/app/theme/default_100_percent/common/infobarbutton_{c|l|r|tl|tr|bl|br}_xxxx.png
> chrome/app/theme/default_100_percent/common/infobarbutton_{c|l|r}_n.png  (n ->
> normal)
> chrome/app/theme/default_100_percent/common/omnibox_{c|l|r}.png
> chrome/app/theme/default_200_percent/common/ev_bubble_{c|l|r}.png
> 
> I also wonder if we can rename this
> 
> chrome/app/theme/default_100_percent/common/help_16.png
> 
> to just help_menu.png. That's consistent with the IDR name and makes more
sense.

[varunjain, 2012-08-10 18:00:54]

Done.

On 2012/08/10 04:15:49, oshima wrote:
> There is another one.
> 
> keyword_search_bubble_{c|l|r}.png
> 
> On 2012/08/10 04:14:46, oshima wrote:
> > Could you please ask UX team (sgabriel?) to fix the filename for these
> > resources?
> > We agree no to use abbreviations.
> > 
> > chrome/app/theme/default_100_percent/common/ev_bubble_{c|l|r}.png   (->
> center,
> > right, left)
> >
>
chrome/app/theme/default_100_percent/common/infobarbutton_{c|l|r|tl|tr|bl|br}_xxxx.png
> > chrome/app/theme/default_100_percent/common/infobarbutton_{c|l|r}_n.png  (n
->
> > normal)
> > chrome/app/theme/default_100_percent/common/omnibox_{c|l|r}.png
> > chrome/app/theme/default_200_percent/common/ev_bubble_{c|l|r}.png
> > 
> > I also wonder if we can rename this
> > 
> > chrome/app/theme/default_100_percent/common/help_16.png
> > 
> > to just help_menu.png. That's consistent with the IDR name and makes more
> sense.

[Nico, 2012-08-10 19:05:08]

Do you intend to land a CL to move everything to the new assets in common/ after
this lands? (If not: I imagined we'd move existing assets from where it
currently is to common/ on demand while updating grd files, instead of in one
huge go.)

[varunjain, 2012-08-10 19:32:04]

yes.. I intend to do the second option you mentioned.

On 2012/08/10 19:05:08, Nico wrote:
> Do you intend to land a CL to move everything to the new assets in common/
after
> this lands? (If not: I imagined we'd move existing assets from where it
> currently is to common/ on demand while updating grd files, instead of in one
> huge go.)

[Nico, 2012-08-10 19:33:51]

Directory location LGTM. I don't know if Oshima has more comments.

On Fri, Aug 10, 2012 at 12:32 PM,  <varunjain@chromium.org> wrote:
> yes.. I intend to do the second option you mentioned.
>
>
> On 2012/08/10 19:05:08, Nico wrote:
>>
>> Do you intend to land a CL to move everything to the new assets in common/
>
> after
>>
>> this lands? (If not: I imagined we'd move existing assets from where it
>> currently is to common/ on demand while updating grd files, instead of in
>> one
>> huge go.)
>
>
>
>
> http://codereview.chromium.org/10829275/

[oshima, 2012-08-10 19:57:51]

On 2012/08/10 19:33:51, Nico wrote:
> Directory location LGTM. I don't know if Oshima has more comments.

There are win/chromeos specific files in common directory. I asked to fix them
offline.

> 
> On Fri, Aug 10, 2012 at 12:32 PM,  <mailto:varunjain@chromium.org> wrote:
> > yes.. I intend to do the second option you mentioned.
> >
> >
> > On 2012/08/10 19:05:08, Nico wrote:
> >>
> >> Do you intend to land a CL to move everything to the new assets in common/
> >
> > after
> >>
> >> this lands? (If not: I imagined we'd move existing assets from where it
> >> currently is to common/ on demand while updating grd files, instead of in
> >> one
> >> huge go.)
> >
> >
> >
> >
> > http://codereview.chromium.org/10829275/

[varunjain, 2012-08-10 21:00:07]

On 2012/08/10 19:57:51, oshima wrote:
> On 2012/08/10 19:33:51, Nico wrote:
> > Directory location LGTM. I don't know if Oshima has more comments.
> 
> There are win/chromeos specific files in common directory. I asked to fix them
> offline.

all files moved to the right place. PTAL.

> 
> > 
> > On Fri, Aug 10, 2012 at 12:32 PM,  <mailto:varunjain@chromium.org> wrote:
> > > yes.. I intend to do the second option you mentioned.
> > >
> > >
> > > On 2012/08/10 19:05:08, Nico wrote:
> > >>
> > >> Do you intend to land a CL to move everything to the new assets in
common/
> > >
> > > after
> > >>
> > >> this lands? (If not: I imagined we'd move existing assets from where it
> > >> currently is to common/ on demand while updating grd files, instead of in
> > >> one
> > >> huge go.)
> > >
> > >
> > >
> > >
> > > http://codereview.chromium.org/10829275/

[oshima, 2012-08-11 03:51:28]

chrome/app/theme/default_100_percent/common/statusbar_volume_icon1.png
chrome/app/theme/default_100_percent/common/statusbar_vpn_dark.png

These must be in cros.

i also think textbutton_xxx_yyy.png must be in ui/resources instead of
chrome/app/theme.

http://code.google.com/p/chromium/source/search?q=textbutton_.*.png&origq=tex...


On 2012/08/10 21:00:07, varunjain wrote:
> On 2012/08/10 19:57:51, oshima wrote:
> > On 2012/08/10 19:33:51, Nico wrote:
> > > Directory location LGTM. I don't know if Oshima has more comments.
> > 
> > There are win/chromeos specific files in common directory. I asked to fix
them
> > offline.
> 
> all files moved to the right place. PTAL.
> 
> > 
> > > 
> > > On Fri, Aug 10, 2012 at 12:32 PM,  <mailto:varunjain@chromium.org> wrote:
> > > > yes.. I intend to do the second option you mentioned.
> > > >
> > > >
> > > > On 2012/08/10 19:05:08, Nico wrote:
> > > >>
> > > >> Do you intend to land a CL to move everything to the new assets in
> common/
> > > >
> > > > after
> > > >>
> > > >> this lands? (If not: I imagined we'd move existing assets from where it
> > > >> currently is to common/ on demand while updating grd files, instead of
in
> > > >> one
> > > >> huge go.)
> > > >
> > > >
> > > >
> > > >
> > > > http://codereview.chromium.org/10829275/

[varunjain, 2012-08-12 19:30:20]

On 2012/08/11 03:51:28, oshima wrote:
> chrome/app/theme/default_100_percent/common/statusbar_volume_icon1.png

moved to cros

> chrome/app/theme/default_100_percent/common/statusbar_vpn_dark.png

seems this is being used in non chromeos
(chrome/browser/resources/options2/browser_options)
> 
> These must be in cros.
> 
> i also think textbutton_xxx_yyy.png must be in ui/resources instead of
> chrome/app/theme.

removed from this CL. will add them when I put up the ui/resources CL.

> 
>
http://code.google.com/p/chromium/source/search?q=textbutton_.*.png&origq=tex...
> 
> 
> On 2012/08/10 21:00:07, varunjain wrote:
> > On 2012/08/10 19:57:51, oshima wrote:
> > > On 2012/08/10 19:33:51, Nico wrote:
> > > > Directory location LGTM. I don't know if Oshima has more comments.
> > > 
> > > There are win/chromeos specific files in common directory. I asked to fix
> them
> > > offline.
> > 
> > all files moved to the right place. PTAL.
> > 
> > > 
> > > > 
> > > > On Fri, Aug 10, 2012 at 12:32 PM,  <mailto:varunjain@chromium.org>
wrote:
> > > > > yes.. I intend to do the second option you mentioned.
> > > > >
> > > > >
> > > > > On 2012/08/10 19:05:08, Nico wrote:
> > > > >>
> > > > >> Do you intend to land a CL to move everything to the new assets in
> > common/
> > > > >
> > > > > after
> > > > >>
> > > > >> this lands? (If not: I imagined we'd move existing assets from where
it
> > > > >> currently is to common/ on demand while updating grd files, instead
of
> in
> > > > >> one
> > > > >> huge go.)
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > http://codereview.chromium.org/10829275/

[oshima, 2012-08-13 02:59:42]

My guess is that it's referenced by the file that is not specific to chromeos,
but used only on chromeos. Adding a flackr who may know more.
LGTM if this is indeed used by non chromeos, or requires code change but
please file a bug to fix this in that case.

[varunjain, 2012-08-13 17:16:53]

On 2012/08/13 02:59:42, oshima wrote:
> My guess is that it's referenced by the file that is not specific to chromeos,
> but used only on chromeos. Adding a flackr who may know more.
> LGTM if this is indeed used by non chromeos, or requires code change but
> please file a bug to fix this in that case.

Just had a chat with flackr. He says that options2 is not cros specific.
However, that file should probably not be needed for non-cros. I'll file a bug
for this and submit this CL. thanks.

[mmenke, 2012-08-30 20:49:25]

On 2012/08/13 17:16:53, varunjain wrote:
> On 2012/08/13 02:59:42, oshima wrote:
> > My guess is that it's referenced by the file that is not specific to
chromeos,
> > but used only on chromeos. Adding a flackr who may know more.
> > LGTM if this is indeed used by non chromeos, or requires code change but
> > please file a bug to fix this in that case.
> 
> Just had a chat with flackr. He says that options2 is not cros specific.
> However, that file should probably not be needed for non-cros. I'll file a bug
> for this and submit this CL. thanks.

You should remove the prerender_succeed_icon.png and prerender_failed_icon.png
before landing this.  They're no longer used.  I was planning on waiting for
this to land before removing them, but seems to be taking a while.  :)

[Nico, 2012-08-30 20:54:07]

On 2012/08/30 20:49:25, Matt Menke wrote:
> On 2012/08/13 17:16:53, varunjain wrote:
> > On 2012/08/13 02:59:42, oshima wrote:
> > > My guess is that it's referenced by the file that is not specific to
> chromeos,
> > > but used only on chromeos. Adding a flackr who may know more.
> > > LGTM if this is indeed used by non chromeos, or requires code change but
> > > please file a bug to fix this in that case.
> > 
> > Just had a chat with flackr. He says that options2 is not cros specific.
> > However, that file should probably not be needed for non-cros. I'll file a
bug
> > for this and submit this CL. thanks.
> 
> You should remove the prerender_succeed_icon.png and prerender_failed_icon.png
> before landing this.  They're no longer used.  I was planning on waiting for
> this to land before removing them, but seems to be taking a while.  :)

I think it's in, the review is just still open (?)

[mmenke, 2012-08-30 21:07:05]

On 2012/08/30 20:54:07, Nico wrote:
> On 2012/08/30 20:49:25, Matt Menke wrote:
> > On 2012/08/13 17:16:53, varunjain wrote:
> > > On 2012/08/13 02:59:42, oshima wrote:
> > > > My guess is that it's referenced by the file that is not specific to
> > chromeos,
> > > > but used only on chromeos. Adding a flackr who may know more.
> > > > LGTM if this is indeed used by non chromeos, or requires code change but
> > > > please file a bug to fix this in that case.
> > > 
> > > Just had a chat with flackr. He says that options2 is not cros specific.
> > > However, that file should probably not be needed for non-cros. I'll file a
> bug
> > > for this and submit this CL. thanks.
> > 
> > You should remove the prerender_succeed_icon.png and
prerender_failed_icon.png
> > before landing this.  They're no longer used.  I was planning on waiting for
> > this to land before removing them, but seems to be taking a while.  :)
> 
> I think it's in, the review is just still open (?)

Oh, you're right...I only saw two sets of prerender icons, and was under the
mistaken impression that this bug added two sets...  Anyways, thanks.