chrome/browser/history/history_extension_api.cc - Issue 10829273: Every VisitItem returned by chrome.history.getVisits has link transition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_extension_api.cc

Issue 10829273: Every VisitItem returned by chrome.history.getVisits has link transition (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/history/history_extension_api.cc

diff --git a/chrome/browser/history/history_extension_api.cc b/chrome/browser/history/history_extension_api.cc

index 54d77939cd02ae0d7b6daf6c010d22196fd019c1..682fac3f817645a0a25ec5aaa4870d5e9531b1e7 100644

--- a/chrome/browser/history/history_extension_api.cc

+++ b/chrome/browser/history/history_extension_api.cc

@@ -73,7 +73,7 @@ scoped_ptr<VisitItem> GetVisitItem(const history::VisitRow& row) {

DCHECK(trans) << "Invalid transition.";

VisitItem::Transition transition = VisitItem::TRANSITION_LINK;

- switch (row.transition) {

+ switch (row.transition & content::PAGE_TRANSITION_CORE_MASK) {

case content::PAGE_TRANSITION_LINK:

transition = VisitItem::TRANSITION_LINK;

break;

« no previous file with comments | « no previous file | no next file » | no next file with comments »