Issue 10829272: Add a function to provide the list of third-party directories which are incompatible with Android

Issue 10829272: Add a function to provide the list of third-party directories which are incompatible with Android (Closed)

Created:
8 years, 4 months ago by Steve Block

Modified:
8 years, 4 months ago

Reviewers:
Nico

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add a function to provide the list of third-party directories which are incompatible with Android. For most directories, we use a regex of whitelisted licenses to parse the 'License' field from the metadata. In some case, for example, where a custom license is used, we rely on a new 'Android Compatibility' field. This functionality will be used by the snapshot tool, which will exclude these incompatible directories from the snapshot in the Android tree. BUG=138921 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151462

Patch Set 1 #

Patch Set 2 : Clean up regex #

Total comments: 3

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -5 lines)			Patch
M	android_webview/tools/webview_licenses.py	View	1	1 chunk	+34 lines, -0 lines	3 comments	Download
M	third_party/README.chromium.template	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/handlebar/README.chromium	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/iccjpeg/README.chromium	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/khronos/README.chromium	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	third_party/libXNVCtrl/README.chromium	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/libjpeg/README.chromium	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/libpng/README.chromium	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/smhasher/README.chromium	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	third_party/zlib/README.chromium	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/licenses.py	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

http://codereview.chromium.org/10829272/diff/2001/android_webview/tools/webview_licenses.py File android_webview/tools/webview_licenses.py (right): http://codereview.chromium.org/10829272/diff/2001/android_webview/tools/webview_licenses.py#newcode44 android_webview/tools/webview_licenses.py:44: 'L?GPL ?v?2(\.[01])?( or later)?', You're whitelisting GPL?

8 years, 4 months ago (2012-08-10 00:36:48 UTC) #2

Steve Block

8 years, 4 months ago (2012-08-10 07:55:22 UTC) #3

Nico

8 years, 4 months ago (2012-08-10 16:42:16 UTC) #4

lgtm

http://codereview.chromium.org/10829272/diff/2001/android_webview/tools/webvi...
File android_webview/tools/webview_licenses.py (right):

http://codereview.chromium.org/10829272/diff/2001/android_webview/tools/webvi...
android_webview/tools/webview_licenses.py:57: if metadata.get('Android
Compatibility', 'no') == 'yes':
nit: "Android Compatibility: yes" reads weird to me. I'd say "Android
Compatible: yes", or even "License Android Compatible: yes" (which is more
explicit). But that's bikeshedding, so feel free to ignore.

Expand Messages | Collapse Messages