Don't reset the layout on RenderText display rect width change.

Don't reset the layout on RenderText display rect width change.

Previously, I thought width was used in layout in render_text_linux.cc,
but it turns out that the width that's passed in to SetupPangoLayout()
gets cleared right after. So the width of the display rect does not
actually affect layout and thus does not need to cause the layout to
be reset.

BUG=137064
TEST=No behavior change.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150908

[msw, 2012-08-09 19:54:49]

FYI, it *should* invalidate the layout for multi-line use once that's supported,
but that's not important right now.

http://codereview.chromium.org/10829261/diff/1/ui/gfx/render_text_linux.cc
File ui/gfx/render_text_linux.cc (right):

http://codereview.chromium.org/10829261/diff/1/ui/gfx/render_text_linux.cc#ne...
ui/gfx/render_text_linux.cc:286: 0,
Why not continue to pass in the width here? It's apparently used to configure
wrapping/eliding in SetupPangoLayoutWithoutFont.

[Alexei Svitkine (slow), 2012-08-09 20:03:01]

http://codereview.chromium.org/10829261/diff/1/ui/gfx/render_text_linux.cc
File ui/gfx/render_text_linux.cc (right):

http://codereview.chromium.org/10829261/diff/1/ui/gfx/render_text_linux.cc#ne...
ui/gfx/render_text_linux.cc:286: 0,
On 2012/08/09 19:54:50, msw wrote:
> Why not continue to pass in the width here? It's apparently used to configure
> wrapping/eliding in SetupPangoLayoutWithoutFont.

See the pango_layout_set_width() call below that just sets it -1
unconditionally. Passing 0 to SetupPangoLayoutWithFontDescription() avoids it
calling pango_layout_set_width() unnecessarily.

Plus, it's less confusing since the current code suggests that width is used in
layout, whereas in reality it isn't (because of the line below).

[msw, 2012-08-09 20:31:33]

Ah, gotcha, LGTM!

[commit-bot: I haz the power, 2012-08-09 20:34:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10829261/1

[commit-bot: I haz the power, 2012-08-09 21:52:00]

Change committed as 150908