Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 10829258: Clean-up inline members of nested classes (webkit/) (Closed)

Created:
8 years, 4 months ago by hans
Modified:
8 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, michaeln, pam+watch_chromium.org, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

Clean-up inline members of nested classes (webkit/) Due to a bug, the Clang-plugin style checker failed to warn about inline constructors, destructors, non-empty virtual methods, etc. for nested classes. The plugin has been fixed, and this patch is part of a clean-up of all the code that now causes the plugin to issue errors. BUG=139346 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150912

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -30 lines) Patch
M webkit/appcache/appcache_disk_cache.h View 2 chunks +2 lines, -12 lines 0 comments Download
M webkit/appcache/appcache_disk_cache.cc View 2 chunks +16 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_file_util.h View 1 chunk +4 lines, -4 lines 0 comments Download
A webkit/fileapi/file_system_file_util.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M webkit/fileapi/webkit_fileapi.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/quota/quota_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/quota/quota_manager.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M webkit/quota/quota_temporary_storage_evictor.h View 1 chunk +1 line, -9 lines 0 comments Download
M webkit/quota/quota_temporary_storage_evictor.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.h View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hans
8 years, 4 months ago (2012-08-09 14:01:16 UTC) #1
brettw
lgtm
8 years, 4 months ago (2012-08-09 19:52:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/10829258/1
8 years, 4 months ago (2012-08-09 20:03:32 UTC) #3
commit-bot: I haz the power
Try job failure for 10829258-1 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=22594 Step "update" is always ...
8 years, 4 months ago (2012-08-09 20:36:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/10829258/1
8 years, 4 months ago (2012-08-09 20:47:21 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 22:08:57 UTC) #6
Change committed as 150912

Powered by Google App Engine
This is Rietveld 408576698