test/same-rule-output-file-name/src/touch.py - Issue 10829252: Fix usage of shlex in unit tests on windows.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/same-rule-output-file-name/src/touch.py

Issue 10829252: Fix usage of shlex in unit tests on windows. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 #!/usr/bin/env python	1 #!/usr/bin/env python

2	2

3 # Copyright (c) 2012 Google Inc. All rights reserved.	3 # Copyright (c) 2012 Google Inc. All rights reserved.

4 # Use of this source code is governed by a BSD-style license that can be	4 # Use of this source code is governed by a BSD-style license that can be

5 # found in the LICENSE file.	5 # found in the LICENSE file.

6	6

7 import shlex	7 import shlex

8 import sys	8 import sys

9	9

10 # Trim quotes	10 # Trim quotes

11 sys.argv[1], = shlex.split(sys.argv[1])	11 sys.argv[1], = shlex.split(sys.argv[1].replace('\\', '\\\\'))
	scottmg 2012/08/09 18:18:49 Is the shlex even necessary? "Trim quotes" isn't v Is the shlex even necessary? "Trim quotes" isn't very convincing to me, the quotes should be pre-trimmed by the actual shell.
12	12

13 f = open(sys.argv[1], 'w+')	13 f = open(sys.argv[1], 'w+')

14 f.write('Hello from touch.py\n')	14 f.write('Hello from touch.py\n')

15 f.close()	15 f.close()

OLD	NEW