Fix usage of shlex in unit tests on windows.

Fix usage of shlex in unit tests on windows.

When shlex was getting an arg like:
  r'"some\interesting\path.file" other_file'

shlex was turning it into:
  ['someinterestingpath.file', 'other_file']

Which _happened_ to work, putting 'someinterestingpath.file' in the working
directory.

This patch doubles up all backslashes prior to splitting, to make the incoming
string conform to shlex's expectations

R=scottmg
Committed: https://code.google.com/p/gyp/source/detail?r=1465

[iannucci, 2012-08-09 18:13:00]

PTAL

[scottmg, 2012-08-09 18:18:48]

https://chromiumcodereview.appspot.com/10829252/diff/1/test/same-rule-output-...
File test/same-rule-output-file-name/src/touch.py (right):

https://chromiumcodereview.appspot.com/10829252/diff/1/test/same-rule-output-...
test/same-rule-output-file-name/src/touch.py:11: sys.argv[1], =
shlex.split(sys.argv[1].replace('\\', '\\\\'))
Is the shlex even necessary? "Trim quotes" isn't very convincing to me, the
quotes should be pre-trimmed by the actual shell.

[iannucci, 2012-08-09 18:24:00]

On 2012/08/09 18:18:48, scottmg wrote:
>
https://chromiumcodereview.appspot.com/10829252/diff/1/test/same-rule-output-...
> File test/same-rule-output-file-name/src/touch.py (right):
> 
>
https://chromiumcodereview.appspot.com/10829252/diff/1/test/same-rule-output-...
> test/same-rule-output-file-name/src/touch.py:11: sys.argv[1], =
> shlex.split(sys.argv[1].replace('\\', '\\\\'))
> Is the shlex even necessary? "Trim quotes" isn't very convincing to me, the
> quotes should be pre-trimmed by the actual shell.

The last arg looks like: '"some\path" other_file', and it's trying to get it
into the form of: ['some\path', 'other_file']. So it's really splitting and
trimming quotes.

It could also be implemented with manual split() and trim() for this unit test.
It works as-is on posix (since shlex likes '/'s just fine).

[iannucci, 2012-08-09 18:24:54]

On 2012/08/09 18:24:00, iannucci wrote:
> On 2012/08/09 18:18:48, scottmg wrote:
> >
>
https://chromiumcodereview.appspot.com/10829252/diff/1/test/same-rule-output-...
> > File test/same-rule-output-file-name/src/touch.py (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/10829252/diff/1/test/same-rule-output-...
> > test/same-rule-output-file-name/src/touch.py:11: sys.argv[1], =
> > shlex.split(sys.argv[1].replace('\\', '\\\\'))
> > Is the shlex even necessary? "Trim quotes" isn't very convincing to me, the
> > quotes should be pre-trimmed by the actual shell.
> 
> The last arg looks like: '"some\path" other_file', and it's trying to get it
> into the form of: ['some\path', 'other_file']. So it's really splitting and
> trimming quotes.
> 
> It could also be implemented with manual split() and trim() for this unit
test.
> It works as-is on posix (since shlex likes '/'s just fine).

Oh, yeah, this is for non-cygwin (i.e. cmd.exe) shells, which do nothing useful
whatsoever :D

[iannucci, 2012-08-09 18:26:00]

On 2012/08/09 18:24:54, iannucci wrote:
> On 2012/08/09 18:24:00, iannucci wrote:
> > On 2012/08/09 18:18:48, scottmg wrote:
> > >
> >
>
https://chromiumcodereview.appspot.com/10829252/diff/1/test/same-rule-output-...
> > > File test/same-rule-output-file-name/src/touch.py (right):
> > > 
> > >
> >
>
https://chromiumcodereview.appspot.com/10829252/diff/1/test/same-rule-output-...
> > > test/same-rule-output-file-name/src/touch.py:11: sys.argv[1], =
> > > shlex.split(sys.argv[1].replace('\\', '\\\\'))
> > > Is the shlex even necessary? "Trim quotes" isn't very convincing to me,
the
> > > quotes should be pre-trimmed by the actual shell.
> > 
> > The last arg looks like: '"some\path" other_file', and it's trying to get it
> > into the form of: ['some\path', 'other_file']. So it's really splitting and
> > trimming quotes.
> > 
> > It could also be implemented with manual split() and trim() for this unit
> test.
> > It works as-is on posix (since shlex likes '/'s just fine).
> 
> Oh, yeah, this is for non-cygwin (i.e. cmd.exe) shells, which do nothing
useful
> whatsoever :D

Oh.... I should really look a which file you were referring to. >_<. I'm not
actually sure it's necessary there. I'll try taking it out. Sorry for emailing
too much.

[scottmg, 2012-08-09 18:26:47]

On 2012/08/09 18:24:54, iannucci wrote:
> On 2012/08/09 18:24:00, iannucci wrote:
> > On 2012/08/09 18:18:48, scottmg wrote:
> > >
> >
>
https://chromiumcodereview.appspot.com/10829252/diff/1/test/same-rule-output-...
> > > File test/same-rule-output-file-name/src/touch.py (right):
> > > 
> > >
> >
>
https://chromiumcodereview.appspot.com/10829252/diff/1/test/same-rule-output-...
> > > test/same-rule-output-file-name/src/touch.py:11: sys.argv[1], =
> > > shlex.split(sys.argv[1].replace('\\', '\\\\'))
> > > Is the shlex even necessary? "Trim quotes" isn't very convincing to me,
the
> > > quotes should be pre-trimmed by the actual shell.
> > 
> > The last arg looks like: '"some\path" other_file', and it's trying to get it
> > into the form of: ['some\path', 'other_file']. So it's really splitting and
> > trimming quotes.

Ah, I see.
 
> > It could also be implemented with manual split() and trim() for this unit
> test.
> > It works as-is on posix (since shlex likes '/'s just fine).

I meant if there was a \ in the posix path, but probably not worth worrying
about.

> Oh, yeah, this is for non-cygwin (i.e. cmd.exe) shells, which do nothing
useful
> whatsoever :D

:P I meant CommandLineToArgvW() which will be what python will have used before
we get here.

Anyway, lgtm.

[iannucci, 2012-08-09 19:31:02]

On 2012/08/09 18:26:47, scottmg wrote:
> On 2012/08/09 18:24:54, iannucci wrote:
> > On 2012/08/09 18:24:00, iannucci wrote:
> > > On 2012/08/09 18:18:48, scottmg wrote:
> > > >
> > >
> >
>
https://chromiumcodereview.appspot.com/10829252/diff/1/test/same-rule-output-...
> > > > File test/same-rule-output-file-name/src/touch.py (right):
> > > > 
> > > >
> > >
> >
>
https://chromiumcodereview.appspot.com/10829252/diff/1/test/same-rule-output-...
> > > > test/same-rule-output-file-name/src/touch.py:11: sys.argv[1], =
> > > > shlex.split(sys.argv[1].replace('\\', '\\\\'))
> > > > Is the shlex even necessary? "Trim quotes" isn't very convincing to me,
> the
> > > > quotes should be pre-trimmed by the actual shell.
> > > 
> > > The last arg looks like: '"some\path" other_file', and it's trying to get
it
> > > into the form of: ['some\path', 'other_file']. So it's really splitting
and
> > > trimming quotes.
> 
> Ah, I see.
>  
> > > It could also be implemented with manual split() and trim() for this unit
> > test.
> > > It works as-is on posix (since shlex likes '/'s just fine).
> 
> I meant if there was a \ in the posix path, but probably not worth worrying
> about.
> 
> > Oh, yeah, this is for non-cygwin (i.e. cmd.exe) shells, which do nothing
> useful
> > whatsoever :D
> 
> :P I meant CommandLineToArgvW() which will be what python will have used
before
> we get here.
> 
> Anyway, lgtm.

Yeah it looks like the shlex's in the touch.py's were completely superfluous
(pending the win32 bot, I guess). It's still necessary for the intermediate_dir
test though. I'll commit as soon as the win32 bot is green.

R

[scottmg, 2012-08-09 19:31:51]

> test though. I'll commit as soon as the win32 bot is green.

sgtm