Issue 10829249: Merge 150607 - Fix logic for VPN badges and network menu order

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829249: Merge 150607 - Fix logic for VPN badges and network menu order (Closed)

Created:
8 years, 4 months ago by stevenjb

Modified:
8 years, 4 months ago

Reviewers:
stevenjb (google-dont-use)

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1229/src/

Visibility:
Public.

More Reviews

Description

Merge 150607 - Fix logic for VPN badges and network menu order There were a few bugs, and some confusing UI. I made the following changes: * Moved the ShouldShowIconInTray() logic into NetworkMenuIcon. * Removed the unused function GetVpnImage() * Made VPN icon code similar to other network types * Changed network display order to: ** Active network ** Connected networks (VPN, Ethernet, Cellular, Wimax, Wifi) ** Unconnected networks (same order) BUG=137941 Review URL: https://chromiumcodereview.appspot.com/10824208 TBR=stevenjb@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150620

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+230 lines, -215 lines)			Patch
M	chrome/browser/chromeos/cros/network_library_impl_stub.cc	View	4 chunks	+11 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_icon.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_icon.cc	View	20 chunks	+84 lines, -76 lines	0 comments	Download
M	chrome/browser/chromeos/system/ash_system_tray_delegate.cc	View	6 chunks	+132 lines, -130 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages