Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 10829233: Remove gdata:: from gdata_file_system_proxy.cc and .h (Closed)

Created:
8 years, 4 months ago by Haruki Sato
Modified:
8 years, 4 months ago
Reviewers:
kochi
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove gdata:: from gdata_file_system_proxy.cc and .h BUG=138418 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150755

Patch Set 1 #

Total comments: 2

Patch Set 2 : more namespace cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M chrome/browser/chromeos/gdata/gdata_file_system_proxy.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc View 1 10 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Haruki Sato
8 years, 4 months ago (2012-08-08 09:01:02 UTC) #1
kochi
http://codereview.chromium.org/10829233/diff/1/chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc File chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc (right): http://codereview.chromium.org/10829233/diff/1/chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc#newcode53 chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc:53: void OnPlatformFileOpened( Can you move these top-level functions into ...
8 years, 4 months ago (2012-08-08 10:59:38 UTC) #2
Haruki Sato
PTAL. Is this what you mean? http://codereview.chromium.org/10829233/diff/1/chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc File chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc (right): http://codereview.chromium.org/10829233/diff/1/chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc#newcode53 chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc:53: void OnPlatformFileOpened( On ...
8 years, 4 months ago (2012-08-09 04:22:04 UTC) #3
kochi
Thanks, it's now very clean! LGTM
8 years, 4 months ago (2012-08-09 05:00:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/10829233/4001
8 years, 4 months ago (2012-08-09 05:03:49 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 06:14:19 UTC) #6
Change committed as 150755

Powered by Google App Engine
This is Rietveld 408576698