Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10829229: Fix duplex defaults. (Closed)

Created:
8 years, 4 months ago by Robert Toscano
Modified:
8 years, 4 months ago
Reviewers:
Albert Bodenhamer
CC:
chromium-reviews, arv (Not doing code reviews)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/browser/resources/print_preview/data/local_parsers.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/print_preview/data/print_ticket_store.js View 1 chunk +3 lines, -0 lines 2 comments Download
M chrome/test/data/webui/print_preview.js View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Robert Toscano
8 years, 4 months ago (2012-08-07 23:56:45 UTC) #1
Albert Bodenhamer
lgtm https://chromiumcodereview.appspot.com/10829229/diff/1/chrome/browser/resources/print_preview/data/print_ticket_store.js File chrome/browser/resources/print_preview/data/print_ticket_store.js (right): https://chromiumcodereview.appspot.com/10829229/diff/1/chrome/browser/resources/print_preview/data/print_ticket_store.js#newcode640 chrome/browser/resources/print_preview/data/print_ticket_store.js:640: Did you mean to add the blank line?
8 years, 4 months ago (2012-08-08 00:01:51 UTC) #2
Robert Toscano
https://chromiumcodereview.appspot.com/10829229/diff/1/chrome/browser/resources/print_preview/data/print_ticket_store.js File chrome/browser/resources/print_preview/data/print_ticket_store.js (right): https://chromiumcodereview.appspot.com/10829229/diff/1/chrome/browser/resources/print_preview/data/print_ticket_store.js#newcode640 chrome/browser/resources/print_preview/data/print_ticket_store.js:640: Yea to separate it from the next step, which ...
8 years, 4 months ago (2012-08-08 00:05:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rltoscano@google.com/10829229/1
8 years, 4 months ago (2012-08-08 00:06:01 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 02:02:29 UTC) #5 
Change committed as 150482

Powered by Google App Engine
This is Rietveld 408576698