Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 10829227: [sync] Cross platform sync tests to be run on Chrome on iOS buildbots (Closed)

Created:
8 years, 4 months ago by Raghu Simha
Modified:
8 years, 4 months ago
Reviewers:
Nico, mmontgomery
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[sync] Cross platform sync tests to be run on Chrome on iOS buildbots This patch adds a class of single client sync integration tests whose primary purpose is to be run on the Chrome on iOS buildbots as part of cross platform sync integration tests. All tests in this class are disabled by default so that they don't run as part of normal chromium buildbot runs. The DISABLED_ annotation will be overridden when the tests are run on the Chrome on iOS buildbots. TBR=thakis@chromium.org BUG=b/6942067 TEST=Run cross platform tests on Chrome on iOS buildbots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
A chrome/browser/sync/test/integration/cross_platform_sync_test.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Raghu Simha
Matthew, please review. Thanks.
8 years, 4 months ago (2012-08-07 22:49:05 UTC) #1
mmontgomery
lgtm
8 years, 4 months ago (2012-08-07 23:08:27 UTC) #2
Raghu Simha
TBR Nico for change to chrome_tests.gypi.
8 years, 4 months ago (2012-08-07 23:21:05 UTC) #3
Nico
8 years, 4 months ago (2012-08-10 17:21:14 UTC) #4
belated lgtm

Powered by Google App Engine
This is Rietveld 408576698