Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 10829219: Browser Plugin: Move to old namespace (Closed)

Created:
8 years, 4 months ago by Fady Samuel
Modified:
8 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, rjkroege
Visibility:
Public.

Description

Browser Plugin: Move to old namespace Move the existing implementation of the browser plugin to the content::old to avoid class name collisions with the new version currently being upstreamed. BUG=140306 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150387

Patch Set 1 #

Patch Set 2 : Style fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -28 lines) Patch
M content/browser/browser_plugin/old/browser_plugin_host.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/old/browser_plugin_host.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/old/browser_plugin_host_helper.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/old/browser_plugin_host_helper.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/old/browser_plugin.h View 2 chunks +9 lines, -4 lines 0 comments Download
M content/renderer/browser_plugin/old/browser_plugin.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/old/browser_plugin_channel_manager.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/old/browser_plugin_channel_manager.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/old/browser_plugin_registry.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/old/browser_plugin_registry.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/old/browser_plugin_var_serialization_rules.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/old/browser_plugin_var_serialization_rules.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/old/guest_to_embedder_channel.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/old/guest_to_embedder_channel.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 4 chunks +11 lines, -6 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 6 chunks +12 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Fady Samuel
8 years, 4 months ago (2012-08-07 14:59:57 UTC) #1
jam
lgtm
8 years, 4 months ago (2012-08-07 16:26:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10829219/1
8 years, 4 months ago (2012-08-07 16:33:27 UTC) #3
commit-bot: I haz the power
Presubmit check for 10829219-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-07 16:33:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10829219/5001
8 years, 4 months ago (2012-08-07 17:57:40 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 19:13:45 UTC) #6
Change committed as 150387

Powered by Google App Engine
This is Rietveld 408576698