Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 10829211: Revert 150240 (broke several bots on the main waterfall) (Closed)

Created:
8 years, 4 months ago by Nico
Modified:
8 years, 4 months ago
Reviewers:
kaiwang
CC:
chromium-reviews, erikwright (departed), MAD, Ilya Sherman, jar (doing other things), brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 150240 (broke several bots on the main waterfall) - CHECK -> DCHECK to prevent breaking exisitng histograms. Review URL: https://chromiumcodereview.appspot.com/10826180 TBR=kaiwang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M base/metrics/histogram.cc View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
8 years, 4 months ago (2012-08-07 03:05:15 UTC) #1
kaiwang
8 years, 4 months ago (2012-08-07 03:08:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698