Chromium Code Reviews
Help | Chromium Project | Sign in
(11)

Issue 10829204: Roll FFmpeg for security fixes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by DaleCurtis
Modified:
2 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Roll FFmpeg for security fixes. Pulls in the following fixes: 70e76e2 mpegprobe: fix misdetection of mp3 a9511ce dsputil: make add_hfyu_left_prediction_sse4() support unaligned src. 12ba355 matroskadec: check element size against stream limit in ebml_parse_elem() 9c06b7f oggdec: Initialize stream index to -1 in ogg_packet. fd73a17 oggdec: simplify start time calculation code. 6b063c8 oggdec: check stream index before using it in ogg_get_length() 7274a3f mov: dont clip timestamps at 0 Also adds the test case for 140165 which I forgot to add when fixing that issue. Test case exposes an issue with a recent CHECK in the audio decoder when we recieve a buffer without timestamps. I've changed this into an if check + decoder error. The AUDIO_GAMING* hashes have changed since acolwell landed a change which strips frames with negative timestamps. BUG=140647 TEST=valgrind+ffmpeg_regression_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -25 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M media/ffmpeg/ffmpeg_regression_tests.cc View 4 chunks +24 lines, -18 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 1 chunk +8 lines, -5 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
DaleCurtis
PTAL.
2 years, 9 months ago (2012-08-06 23:10:48 UTC) #1
acolwell GONE FROM CHROMIUM
2 years, 9 months ago (2012-08-06 23:37:50 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be