Add a presubmit check for boolean policy polarity.

Add a presubmit check for boolean policy polarity.

The current situation of boolean policy switches either enabling or
disabling something is pretty arbitrary (although tending to be the
inverse of the browser default). It's much easier to reason about
XYZEnabled-style settings, so we prefer those going forward.

BUG=chromium:85687
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150333

[Mattias Nissler (ping if slow), 2012-08-06 20:34:41]

Please review.

[Joao da Silva, 2012-08-06 21:49:04]

lgtm

Quite a patch that was sent to the try bots :-)

https://chromiumcodereview.appspot.com/10829197/diff/1/chrome/app/policy/synt...
File chrome/app/policy/syntax_check_policy_template_json.py (right):

https://chromiumcodereview.appspot.com/10829197/diff/1/chrome/app/policy/synt...
chrome/app/policy/syntax_check_policy_template_json.py:158: "disable" in
policy.get('name').lower() and
Nit: 'disable' with single quotes

[Mattias Nissler (ping if slow), 2012-08-07 08:20:07]

Thanks for the review!

https://chromiumcodereview.appspot.com/10829197/diff/1/chrome/app/policy/synt...
File chrome/app/policy/syntax_check_policy_template_json.py (right):

https://chromiumcodereview.appspot.com/10829197/diff/1/chrome/app/policy/synt...
chrome/app/policy/syntax_check_policy_template_json.py:158: "disable" in
policy.get('name').lower() and
On 2012/08/06 21:49:05, Joao da Silva wrote:
> Nit: 'disable' with single quotes

Done.

[commit-bot: I haz the power, 2012-08-07 10:34:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/10829197/3002

[commit-bot: I haz the power, 2012-08-07 12:04:16]

Change committed as 150333