Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 10829195: Speculative resource prefetching - Not modify resource_type for MAIN_FRAME requests. (Closed)

Created:
8 years, 4 months ago by Shishir
Modified:
8 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Speculative resource prefetching - Not modify resource_type for MAIN_FRAME requests. We override resource_types for subresources based on mime_types to not have to deal with types such as PREFETCH, SUBRESOURCE, etc. But we should not do this for main frame requests which we want to treat separately. BUG=140838 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150221

Patch Set 1 #

Patch Set 2 : Remove extra braces. #

Total comments: 2

Patch Set 3 : Fixing spacing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M chrome/browser/net/resource_prefetch_predictor_observer.cc View 1 2 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Shishir
Please take a look. Adding jar for chrome/browser/net/...
8 years, 4 months ago (2012-08-06 18:22:18 UTC) #1
jar (doing other things)
Please fix nearby nit while editing the file. The change LGTM. https://chromiumcodereview.appspot.com/10829195/diff/3001/chrome/browser/net/resource_prefetch_predictor_observer.cc File chrome/browser/net/resource_prefetch_predictor_observer.cc (right): ...
8 years, 4 months ago (2012-08-06 19:02:53 UTC) #2
Shishir
https://chromiumcodereview.appspot.com/10829195/diff/3001/chrome/browser/net/resource_prefetch_predictor_observer.cc File chrome/browser/net/resource_prefetch_predictor_observer.cc (right): https://chromiumcodereview.appspot.com/10829195/diff/3001/chrome/browser/net/resource_prefetch_predictor_observer.cc#newcode60 chrome/browser/net/resource_prefetch_predictor_observer.cc:60: : predictor_(predictor->AsWeakPtr()) { On 2012/08/06 19:02:53, jar wrote: > ...
8 years, 4 months ago (2012-08-06 19:11:10 UTC) #3
jar (doing other things)
lgtm
8 years, 4 months ago (2012-08-06 19:22:44 UTC) #4
dominich
lgtm
8 years, 4 months ago (2012-08-06 19:54:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shishir@chromium.org/10829195/1002
8 years, 4 months ago (2012-08-07 00:01:20 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 01:28:35 UTC) #7
Change committed as 150221

Powered by Google App Engine
This is Rietveld 408576698