Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 10829194: chromeos: Open app using profile returned from GetProfileForNewWindows. (Closed)

Created:
8 years, 4 months ago by xiyuan
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

chromeos: Open app using profile returned from GetProfileForNewWindows. BUG=138860 TEST=Verify fix for 138860 and in non-guest mode apps run under the same profile as before. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
xiyuan
8 years, 4 months ago (2012-08-06 17:24:18 UTC) #1
sky
LGTM
8 years, 4 months ago (2012-08-06 17:28:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10829194/1
8 years, 4 months ago (2012-08-06 19:22:58 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-06 19:52:28 UTC) #4
Try job failure for 10829194-1 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Powered by Google App Engine
This is Rietveld 408576698