Issue 10829191: Measure DNS resolution waste from not always performing AF_UNSPEC lookups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829191: Measure DNS resolution waste from not always performing AF_UNSPEC lookups. (Closed)

Created:
8 years, 4 months ago by pauljensen

Modified:
8 years, 4 months ago

Reviewers:
szym

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Measure DNS resolution waste from not always performing AF_UNSPEC lookups. BUG=139811 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151312

Patch Set 2 : Address szym's nits. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -2 lines)			Patch
	M	net/base/host_resolver_impl.cc	View	1	1 chunk	+40 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pauljensen

I broke off this CL from 10843072 and addressed syzm's and mmenke's concern when |default_address_family_ ...

8 years, 4 months ago (2012-08-06 13:42:46 UTC) #1

szym

lgtm with a couple nits. http://codereview.chromium.org/10829191/diff/1/net/base/host_resolver_impl.cc File net/base/host_resolver_impl.cc (right): http://codereview.chromium.org/10829191/diff/1/net/base/host_resolver_impl.cc#newcode1828 net/base/host_resolver_impl.cc:1828: bool found = cache_entry ...

8 years, 4 months ago (2012-08-07 23:17:31 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pauljensen@chromium.org/10829191/4001

8 years, 4 months ago (2012-08-13 17:00:27 UTC) #3

Change committed as 151312

Expand Messages | Collapse Messages

Issue 10829191: Measure DNS resolution waste from not always performing AF_UNSPEC lookups. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address szym's nits. #

Messages