Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Issue 10829189: Update the webrtc camera and microphone icons for windows, linux and mac. (Closed)

Created:
8 years, 4 months ago by no longer working on chromium
Modified:
8 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Update the webrtc camera and microphone icons for windows, linux and mac. It mainly fixed the problem on Mac where the bitmap shown in the OS X menu bar while capturing is active doesn't have a HiDPI version. BUG=138420 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153499

Patch Set 1 #

Patch Set 2 : assets were landed on a separate CL, rebased. #

Patch Set 3 : rebased again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, --4 lines) Patch
D chrome/app/theme/default_100_percent/infobar_camera.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/infobar_microphone.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/infobar_camera.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/infobar_microphone.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
D chrome/app/theme/touch_100_percent/infobar_camera.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/touch_100_percent/infobar_microphone.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
no longer working on chromium
8 years, 4 months ago (2012-08-06 11:00:15 UTC) #1
no longer working on chromium
Hi cpu, could you please give me your owner stamp to land the new icons? ...
8 years, 4 months ago (2012-08-06 11:02:33 UTC) #2
oshima
Hi, How did you get these images? We're switching to new directory structure (osx/ common/ ...
8 years, 4 months ago (2012-08-07 03:30:32 UTC) #3
no longer working on chromium
On 2012/08/07 03:30:32, oshima wrote: > Hi, > > How did you get these images? ...
8 years, 4 months ago (2012-08-07 07:38:52 UTC) #4
oshima
lgtm We discussed offline and decided to land this as is for m22, as we ...
8 years, 4 months ago (2012-08-07 08:05:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/10829189/1
8 years, 4 months ago (2012-08-07 08:06:17 UTC) #6
commit-bot: I haz the power
Presubmit check for 10829189-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-07 08:06:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/10829189/1
8 years, 4 months ago (2012-08-07 08:21:30 UTC) #8
commit-bot: I haz the power
Presubmit check for 10829189-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-07 08:21:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/10829189/13002
8 years, 3 months ago (2012-08-27 13:10:03 UTC) #10
commit-bot: I haz the power
8 years, 3 months ago (2012-08-27 17:26:16 UTC) #11
Change committed as 153499

Powered by Google App Engine
This is Rietveld 408576698