Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Unified Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 10829186: Tabs API is usable without tabs permission. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: . Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permission_set_unittest.cc
diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc
index 17f7cca2dbe1f21e254a4344900fece2f1ef3fd8..3288597d6093041a9f7019378ffe53210bd3f42b 100644
--- a/chrome/common/extensions/permissions/permission_set_unittest.cc
+++ b/chrome/common/extensions/permissions/permission_set_unittest.cc
@@ -647,20 +647,21 @@ TEST(PermissionsTest, DefaultFunctionAccess) {
{ "bookmarks", false },
{ "cookies", false },
{ "history", false },
- { "tabs.onUpdated", false },
// Make sure we find the module name after stripping '.' and '/'.
{ "browserAction/abcd/onClick", true },
{ "browserAction.abcd.onClick", true },
// Test Tabs functions.
{ "tabs.create", true},
{ "tabs.update", true},
- { "tabs.getSelected", false},
+ { "tabs.getSelected", true},
+ { "tabs.onUpdated", true },
};
scoped_refptr<PermissionSet> empty = new PermissionSet();
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTests); ++i) {
EXPECT_EQ(kTests[i].expect_success,
- empty->HasAccessToFunction(kTests[i].permission_name));
+ empty->HasAccessToFunction(kTests[i].permission_name))
+ << "Permission being tested: " << kTests[i].permission_name;
}
}

Powered by Google App Engine
This is Rietveld 408576698