Remove a few unneeded includes

Remove a few unneeded includes

BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150028

[viettrungluu, 2012-08-04 05:36:22]

https://chromiumcodereview.appspot.com/10829184/diff/1/chrome/browser/favicon...
File chrome/browser/favicon/favicon_tab_helper.h (left):

https://chromiumcodereview.appspot.com/10829184/diff/1/chrome/browser/favicon...
chrome/browser/favicon/favicon_tab_helper.h:16: #include "googleurl/src/gurl.h"
Should you add this include to the .cc file?

[Nico, 2012-08-04 05:40:15]

https://chromiumcodereview.appspot.com/10829184/diff/1/chrome/browser/favicon...
File chrome/browser/favicon/favicon_tab_helper.h (left):

https://chromiumcodereview.appspot.com/10829184/diff/1/chrome/browser/favicon...
chrome/browser/favicon/favicon_tab_helper.h:16: #include "googleurl/src/gurl.h"
On 2012/08/04 05:36:22, viettrungluu wrote:
> Should you add this include to the .cc file?

No need, the cc only passes GURL references around to functions in other
translation units.

[viettrungluu, 2012-08-04 05:42:07]

On 2012/08/04 05:40:15, Nico wrote:
>
https://chromiumcodereview.appspot.com/10829184/diff/1/chrome/browser/favicon...
> File chrome/browser/favicon/favicon_tab_helper.h (left):
> 
>
https://chromiumcodereview.appspot.com/10829184/diff/1/chrome/browser/favicon...
> chrome/browser/favicon/favicon_tab_helper.h:16: #include
"googleurl/src/gurl.h"
> On 2012/08/04 05:36:22, viettrungluu wrote:
> > Should you add this include to the .cc file?
> 
> No need, the cc only passes GURL references around to functions in other
> translation units.

I stand corrected then.

LGTM, assuming it builds.

But before you commit, we need to have a meeting to discuss plans for your
bikeshed.

[Nico, 2012-08-04 05:43:04]

On 2012/08/04 05:42:07, viettrungluu wrote:
> On 2012/08/04 05:40:15, Nico wrote:
> >
>
https://chromiumcodereview.appspot.com/10829184/diff/1/chrome/browser/favicon...
> > File chrome/browser/favicon/favicon_tab_helper.h (left):
> > 
> >
>
https://chromiumcodereview.appspot.com/10829184/diff/1/chrome/browser/favicon...
> > chrome/browser/favicon/favicon_tab_helper.h:16: #include
> "googleurl/src/gurl.h"
> > On 2012/08/04 05:36:22, viettrungluu wrote:
> > > Should you add this include to the .cc file?
> > 
> > No need, the cc only passes GURL references around to functions in other
> > translation units.
> 
> I stand corrected then.
> 
> LGTM, assuming it builds.
> 
> But before you commit, we need to have a meeting to discuss plans for your
> bikeshed.

The cq likely won't land it soon anyway.

[commit-bot: I haz the power, 2012-08-04 05:48:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10829184/1

[commit-bot: I haz the power, 2012-08-04 06:13:24]

Try job failure for 10829184-1 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2012-08-04 06:36:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10829184/7003

[commit-bot: I haz the power, 2012-08-04 06:54:27]

Try job failure for 10829184-7003 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-04 06:59:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10829184/7003

[commit-bot: I haz the power, 2012-08-04 07:24:10]

Try job failure for 10829184-7003 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-04 07:39:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10829184/7003

[commit-bot: I haz the power, 2012-08-04 09:04:36]

Change committed as 150028