Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 10829182: Only dlopen() OMX/VAAPI libs in the GPU process, and only lazily dlsym() their symbols. (Closed)

Created:
8 years, 4 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org, Pawel Osciak
Visibility:
Public.

Description

Only dlopen() OMX/VAAPI libs in the GPU process, and only lazily dlsym() their symbols. BUG=140412 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150007

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -71 lines) Patch
M content/common/gpu/media/omx_video_decode_accelerator.h View 3 chunks +10 lines, -0 lines 0 comments Download
M content/common/gpu/media/omx_video_decode_accelerator.cc View 5 chunks +37 lines, -18 lines 0 comments Download
M content/common/gpu/media/vaapi_h264_decoder.h View 2 chunks +10 lines, -0 lines 0 comments Download
M content/common/gpu/media/vaapi_h264_decoder.cc View 4 chunks +83 lines, -52 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.h View 1 2 chunks +8 lines, -1 line 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/gpu/gpu_main.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ami GONE FROM CHROMIUM
piman: please review posciak: FYI
8 years, 4 months ago (2012-08-04 00:44:11 UTC) #1
piman
+Jorge just in case. LGTM for me. https://chromiumcodereview.appspot.com/10829182/diff/1/content/common/gpu/media/vaapi_video_decode_accelerator.cc File content/common/gpu/media/vaapi_video_decode_accelerator.cc (right): https://chromiumcodereview.appspot.com/10829182/diff/1/content/common/gpu/media/vaapi_video_decode_accelerator.cc#newcode70 content/common/gpu/media/vaapi_video_decode_accelerator.cc:70: static bool ...
8 years, 4 months ago (2012-08-04 01:02:23 UTC) #2
Jorge Lucangeli Obes
As long as we dlopen() before calling InitializeSandbox, we're good =). lgtm
8 years, 4 months ago (2012-08-04 01:10:55 UTC) #3
Ami GONE FROM CHROMIUM
https://chromiumcodereview.appspot.com/10829182/diff/1/content/common/gpu/media/vaapi_video_decode_accelerator.cc File content/common/gpu/media/vaapi_video_decode_accelerator.cc (right): https://chromiumcodereview.appspot.com/10829182/diff/1/content/common/gpu/media/vaapi_video_decode_accelerator.cc#newcode70 content/common/gpu/media/vaapi_video_decode_accelerator.cc:70: static bool vaapi_functions_initialized = PostSandboxInitialization(); On 2012/08/04 01:02:24, piman ...
8 years, 4 months ago (2012-08-04 01:44:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10829182/5001
8 years, 4 months ago (2012-08-04 01:45:00 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-04 03:02:50 UTC) #6
Change committed as 150007

Powered by Google App Engine
This is Rietveld 408576698