Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 10829180: Move cursor when it's hidden so that UX can update correctly (Closed)

Created:
8 years, 4 months ago by DaveMoore
Modified:
8 years, 4 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Move cursor when it's hidden so that UX can update correctly BUG=136057 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151705

Patch Set 1 #

Patch Set 2 : Added test #

Total comments: 2

Patch Set 3 : Post position change #

Patch Set 4 : Comments #

Patch Set 5 : Disable test for windows #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -2 lines) Patch
M ash/test/ash_test_base.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/env.h View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M ui/aura/env.cc View 1 2 3 2 chunks +14 lines, -0 lines 1 comment Download
M ui/aura/root_window.cc View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M ui/aura/root_window_unittest.cc View 1 2 3 4 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
DaveMoore
8 years, 4 months ago (2012-08-04 17:45:07 UTC) #1
oshima
https://chromiumcodereview.appspot.com/10829180/diff/2001/ui/aura/root_window.cc File ui/aura/root_window.cc (right): https://chromiumcodereview.appspot.com/10829180/diff/2001/ui/aura/root_window.cc#newcode240 ui/aura/root_window.cc:240: } I think it's better to change last_mouse_location to ...
8 years, 4 months ago (2012-08-06 03:24:24 UTC) #2
DaveMoore
8 years, 4 months ago (2012-08-14 00:02:28 UTC) #3
DaveMoore
8 years, 4 months ago (2012-08-14 15:48:55 UTC) #4
sky
https://chromiumcodereview.appspot.com/10829180/diff/12001/ui/aura/env.cc File ui/aura/env.cc (right): https://chromiumcodereview.appspot.com/10829180/diff/12001/ui/aura/env.cc#newcode81 ui/aura/env.cc:81: last_mouse_location_ = gfx::Point(-10000, -10000); Won't this cause all sorts ...
8 years, 4 months ago (2012-08-14 16:01:00 UTC) #5
sky
LGTM
8 years, 4 months ago (2012-08-14 23:56:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/10829180/12001
8 years, 4 months ago (2012-08-15 00:16:39 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 02:17:56 UTC) #8
Try job failure for 10829180-12001 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, steps "interactive_ui_tests, browser_tests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698