Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1390)

Unified Diff: vm/object.h

Issue 10829177: Address review comments. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/exceptions.cc ('k') | vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/object.h
===================================================================
--- vm/object.h (revision 10251)
+++ vm/object.h (working copy)
@@ -5239,16 +5239,16 @@
RawFunction* FunctionAtFrame(intptr_t frame_index) const;
RawCode* CodeAtFrame(intptr_t frame_index) const;
RawSmi* PcOffsetAtFrame(intptr_t frame_index) const;
- void Append(const GrowableArray<uword>& stack_frame_pcs,
- const GrowableObjectArray& func_list,
- const GrowableObjectArray& code_list) const;
+ void Append(const GrowableObjectArray& func_list,
+ const GrowableObjectArray& code_list,
+ const GrowableObjectArray& pc_offset_list) const;
static intptr_t InstanceSize() {
return RoundedAllocationSize(sizeof(RawStacktrace));
}
- static RawStacktrace* New(const GrowableArray<uword>& stack_frame_pcs,
- const GrowableObjectArray& func_list,
+ static RawStacktrace* New(const GrowableObjectArray& func_list,
const GrowableObjectArray& code_list,
+ const GrowableObjectArray& pc_offset_list,
Heap::Space space = Heap::kNew);
const char* ToCStringInternal(bool verbose) const;
@@ -5257,8 +5257,6 @@
void set_function_array(const Array& function_array) const;
void set_code_array(const Array& code_array) const;
void set_pc_offset_array(const Array& pc_offset_array) const;
- void SetupStacktrace(intptr_t index,
- const GrowableArray<uword>& stack_frame_pcs) const;
HEAP_OBJECT_IMPLEMENTATION(Stacktrace, Instance);
friend class Class;
« no previous file with comments | « vm/exceptions.cc ('k') | vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698