Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: ui/views/controls/combobox/native_combobox_views.cc

Issue 10829176: Update drop down menu look & feel (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Delete POSITION_OVER_BOUNDS related code Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/combobox/native_combobox_views.cc
diff --git a/ui/views/controls/combobox/native_combobox_views.cc b/ui/views/controls/combobox/native_combobox_views.cc
index e0032c30986a737c102b6d88815f6ef45f1ba760..66d88a7d985af22d8652270f2eb448f500749651 100644
--- a/ui/views/controls/combobox/native_combobox_views.cc
+++ b/ui/views/controls/combobox/native_combobox_views.cc
@@ -57,7 +57,7 @@ NativeComboboxViews::NativeComboboxViews(Combobox* combobox)
: combobox_(combobox),
text_border_(new FocusableBorder()),
disclosure_arrow_(ui::ResourceBundle::GetSharedInstance().GetImageNamed(
- IDR_DISCLOSURE_ARROW).ToImageSkia()),
+ IDR_MENU_DROPARROW).ToImageSkia()),
dropdown_open_(false),
selected_index_(-1),
content_width_(0),
@@ -326,11 +326,6 @@ void NativeComboboxViews::ShowDropDownMenu() {
SubmenuView* submenu = menu->CreateSubmenu();
submenu->set_minimum_preferred_width(size().width());
-#if defined(USE_AURA)
- // Aura style is to have the menu over the bounds. Below bounds is default.
- menu->set_menu_position(views::MenuItemView::POSITION_OVER_BOUNDS);
-#endif
-
gfx::Rect lb = GetLocalBounds();
gfx::Point menu_position(lb.origin());
View::ConvertPointToScreen(this, &menu_position);

Powered by Google App Engine
This is Rietveld 408576698