Update drop down menu look & feel

ui/views/controls/combobox/native_combobox_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/combobox/native_combobox_views.h"
 
 #include <algorithm>
 
 #include "grit/ui_resources.h"
 #include "ui/base/keycodes/keyboard_codes.h"
@@ skipping 39 matching lines @@
 
 namespace views {
 
 const char NativeComboboxViews::kViewClassName[] =
     "views/NativeComboboxViews";
 
 NativeComboboxViews::NativeComboboxViews(Combobox* combobox)
     : combobox_(combobox),
       text_border_(new FocusableBorder()),
       disclosure_arrow_(ui::ResourceBundle::GetSharedInstance().GetImageNamed(
-          IDR_DISCLOSURE_ARROW).ToImageSkia()),

[sky, 2012/08/06 22:57:59]

Update the grd file and remove the image too.

[Harry McCleave, 2012/08/06 23:41:27]

Done.

+          IDR_MENU_DROPARROW).ToImageSkia()),
       dropdown_open_(false),
       selected_index_(-1),
       content_width_(0),
       content_height_(0) {
   set_border(text_border_);
 }
 
 NativeComboboxViews::~NativeComboboxViews() {
 }
 
@@ skipping 248 matching lines @@
 void NativeComboboxViews::ShowDropDownMenu() {
 
   if (!dropdown_list_menu_runner_.get())
     UpdateFromModel();
 
   // Extend the menu to the width of the combobox.
   MenuItemView* menu = dropdown_list_menu_runner_->GetMenu();
   SubmenuView* submenu = menu->CreateSubmenu();
   submenu->set_minimum_preferred_width(size().width());
 
-#if defined(USE_AURA)
-  // Aura style is to have the menu over the bounds. Below bounds is default.
-  menu->set_menu_position(views::MenuItemView::POSITION_OVER_BOUNDS);

[sky, 2012/08/06 22:57:59]

This code only exists for aura. IF it's not needed, remove set_menu_position and
related code.

[Harry McCleave, 2012/08/06 23:41:27]

Done? (is the mergeing of [requested|actual]_menu_position into menu_position
still relevant or should that go as well?

-#endif
-
   gfx::Rect lb = GetLocalBounds();
   gfx::Point menu_position(lb.origin());
   View::ConvertPointToScreen(this, &menu_position);
   if (menu_position.x() < 0)
       menu_position.set_x(0);
 
   gfx::Rect bounds(menu_position, lb.size());
 
   dropdown_open_ = true;
   if (dropdown_list_menu_runner_->RunMenuAt(
@@ skipping 13 matching lines @@
 
 #if defined(USE_AURA)
 // static
 NativeComboboxWrapper* NativeComboboxWrapper::CreateWrapper(
     Combobox* combobox) {
   return new NativeComboboxViews(combobox);
 }
 #endif
 
 }  // namespace views