Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 10829173: Revert 149869 because it broke ash_unittests on win_aura and linux_chromeos. (Closed)

Created:
8 years, 4 months ago by sadrul
Modified:
8 years, 4 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 149869 because it broke ash_unittests on win_aura and linux_chromeos. """ 2nd display should show the same background as login/lock screen: Added special container for background on lock screen. Background view can now be created in specific container. Disabled lock screen wallpaper implementation based on serving PNG image via data source. BUG=136853, 137581 TEST=Lock screen on multimonitor configuration. Check that windows on secondary display are hidden with background. Review URL: https://chromiumcodereview.appspot.com/10810039 TBR=antrim@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149878

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -324 lines) Patch
M ash/ash.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/desktop_background/desktop_background_controller.h View 2 chunks +7 lines, -32 lines 0 comments Download
M ash/desktop_background/desktop_background_controller.cc View 6 chunks +48 lines, -117 lines 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 7 chunks +9 lines, -8 lines 0 comments Download
D ash/desktop_background/desktop_background_widget_controller.h View 1 chunk +0 lines, -54 lines 0 comments Download
D ash/desktop_background/desktop_background_widget_controller.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M ash/root_window_controller.cc View 3 chunks +1 line, -11 lines 0 comments Download
M ash/shell_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/shell_unittest.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M ash/shell_window_ids.h View 1 chunk +7 lines, -10 lines 0 comments Download
M ash/wm/root_window_layout_manager.h View 3 chunks +16 lines, -1 line 0 comments Download
M ash/wm/root_window_layout_manager.cc View 3 chunks +19 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/lock_window_aura.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_account_picker.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
8 years, 4 months ago (2012-08-03 18:39:19 UTC) #1
Nikita (slow)
8 years, 4 months ago (2012-08-03 20:51:25 UTC) #2
Please include links to buildbot builds next time.

Powered by Google App Engine
This is Rietveld 408576698