Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: src/x64/lithium-x64.h

Issue 10829169: Refactor Math.min/max to be a single HInstruction. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: review feedback; removed VORR instruction Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 V(InstanceOfKnownGlobal) \ 108 V(InstanceOfKnownGlobal) \
109 V(InstructionGap) \ 109 V(InstructionGap) \
110 V(Integer32ToDouble) \ 110 V(Integer32ToDouble) \
111 V(InvokeFunction) \ 111 V(InvokeFunction) \
112 V(IsConstructCallAndBranch) \ 112 V(IsConstructCallAndBranch) \
113 V(IsNilAndBranch) \ 113 V(IsNilAndBranch) \
114 V(IsObjectAndBranch) \ 114 V(IsObjectAndBranch) \
115 V(IsStringAndBranch) \ 115 V(IsStringAndBranch) \
116 V(IsSmiAndBranch) \ 116 V(IsSmiAndBranch) \
117 V(IsUndetectableAndBranch) \ 117 V(IsUndetectableAndBranch) \
118 V(StringCompareAndBranch) \
119 V(JSArrayLength) \ 118 V(JSArrayLength) \
120 V(Label) \ 119 V(Label) \
121 V(LazyBailout) \ 120 V(LazyBailout) \
122 V(LoadContextSlot) \ 121 V(LoadContextSlot) \
123 V(LoadElements) \ 122 V(LoadElements) \
124 V(LoadExternalArrayPointer) \ 123 V(LoadExternalArrayPointer) \
125 V(LoadFunctionPrototype) \ 124 V(LoadFunctionPrototype) \
126 V(LoadGlobalCell) \ 125 V(LoadGlobalCell) \
127 V(LoadGlobalGeneric) \ 126 V(LoadGlobalGeneric) \
128 V(LoadKeyedFastDoubleElement) \ 127 V(LoadKeyedFastDoubleElement) \
129 V(LoadKeyedFastElement) \ 128 V(LoadKeyedFastElement) \
130 V(LoadKeyedGeneric) \ 129 V(LoadKeyedGeneric) \
131 V(LoadKeyedSpecializedArrayElement) \ 130 V(LoadKeyedSpecializedArrayElement) \
132 V(LoadNamedField) \ 131 V(LoadNamedField) \
133 V(LoadNamedFieldPolymorphic) \ 132 V(LoadNamedFieldPolymorphic) \
134 V(LoadNamedGeneric) \ 133 V(LoadNamedGeneric) \
135 V(MathFloorOfDiv) \ 134 V(MathFloorOfDiv) \
135 V(MathMinMax) \
136 V(ModI) \ 136 V(ModI) \
137 V(MulI) \ 137 V(MulI) \
138 V(NumberTagD) \ 138 V(NumberTagD) \
139 V(NumberTagI) \ 139 V(NumberTagI) \
140 V(NumberUntagD) \ 140 V(NumberUntagD) \
141 V(ObjectLiteral) \ 141 V(ObjectLiteral) \
142 V(OsrEntry) \ 142 V(OsrEntry) \
143 V(OuterContext) \ 143 V(OuterContext) \
144 V(Parameter) \ 144 V(Parameter) \
145 V(Power) \ 145 V(Power) \
(...skipping 10 matching lines...) Expand all
156 V(StoreGlobalGeneric) \ 156 V(StoreGlobalGeneric) \
157 V(StoreKeyedFastDoubleElement) \ 157 V(StoreKeyedFastDoubleElement) \
158 V(StoreKeyedFastElement) \ 158 V(StoreKeyedFastElement) \
159 V(StoreKeyedGeneric) \ 159 V(StoreKeyedGeneric) \
160 V(StoreKeyedSpecializedArrayElement) \ 160 V(StoreKeyedSpecializedArrayElement) \
161 V(StoreNamedField) \ 161 V(StoreNamedField) \
162 V(StoreNamedGeneric) \ 162 V(StoreNamedGeneric) \
163 V(StringAdd) \ 163 V(StringAdd) \
164 V(StringCharCodeAt) \ 164 V(StringCharCodeAt) \
165 V(StringCharFromCode) \ 165 V(StringCharFromCode) \
166 V(StringCompareAndBranch) \
166 V(StringLength) \ 167 V(StringLength) \
167 V(SubI) \ 168 V(SubI) \
168 V(TaggedToI) \ 169 V(TaggedToI) \
169 V(ThisFunction) \ 170 V(ThisFunction) \
170 V(Throw) \ 171 V(Throw) \
171 V(ToFastProperties) \ 172 V(ToFastProperties) \
172 V(TransitionElementsKind) \ 173 V(TransitionElementsKind) \
173 V(Typeof) \ 174 V(Typeof) \
174 V(TypeofIsAndBranch) \ 175 V(TypeofIsAndBranch) \
175 V(UnaryMathOperation) \ 176 V(UnaryMathOperation) \
(...skipping 881 matching lines...) Expand 10 before | Expand all | Expand 10 after
1057 LAddI(LOperand* left, LOperand* right) { 1058 LAddI(LOperand* left, LOperand* right) {
1058 inputs_[0] = left; 1059 inputs_[0] = left;
1059 inputs_[1] = right; 1060 inputs_[1] = right;
1060 } 1061 }
1061 1062
1062 DECLARE_CONCRETE_INSTRUCTION(AddI, "add-i") 1063 DECLARE_CONCRETE_INSTRUCTION(AddI, "add-i")
1063 DECLARE_HYDROGEN_ACCESSOR(Add) 1064 DECLARE_HYDROGEN_ACCESSOR(Add)
1064 }; 1065 };
1065 1066
1066 1067
1068 class LMathMinMax: public LTemplateInstruction<1, 2, 0> {
1069 public:
1070 LMathMinMax(LOperand* left, LOperand* right) {
1071 inputs_[0] = left;
1072 inputs_[1] = right;
1073 }
1074
1075 DECLARE_CONCRETE_INSTRUCTION(MathMinMax, "min-max")
1076 DECLARE_HYDROGEN_ACCESSOR(MathMinMax)
1077 };
1078
1079
1067 class LPower: public LTemplateInstruction<1, 2, 0> { 1080 class LPower: public LTemplateInstruction<1, 2, 0> {
1068 public: 1081 public:
1069 LPower(LOperand* left, LOperand* right) { 1082 LPower(LOperand* left, LOperand* right) {
1070 inputs_[0] = left; 1083 inputs_[0] = left;
1071 inputs_[1] = right; 1084 inputs_[1] = right;
1072 } 1085 }
1073 1086
1074 DECLARE_CONCRETE_INSTRUCTION(Power, "power") 1087 DECLARE_CONCRETE_INSTRUCTION(Power, "power")
1075 DECLARE_HYDROGEN_ACCESSOR(Power) 1088 DECLARE_HYDROGEN_ACCESSOR(Power)
1076 }; 1089 };
(...skipping 1268 matching lines...) Expand 10 before | Expand all | Expand 10 after
2345 2358
2346 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2359 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2347 }; 2360 };
2348 2361
2349 #undef DECLARE_HYDROGEN_ACCESSOR 2362 #undef DECLARE_HYDROGEN_ACCESSOR
2350 #undef DECLARE_CONCRETE_INSTRUCTION 2363 #undef DECLARE_CONCRETE_INSTRUCTION
2351 2364
2352 } } // namespace v8::int 2365 } } // namespace v8::int
2353 2366
2354 #endif // V8_X64_LITHIUM_X64_H_ 2367 #endif // V8_X64_LITHIUM_X64_H_
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698