Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: src/ia32/lithium-ia32.h

Issue 10829169: Refactor Math.min/max to be a single HInstruction. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: review feedback; removed VORR instruction Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 V(InstanceOfKnownGlobal) \ 102 V(InstanceOfKnownGlobal) \
103 V(InstructionGap) \ 103 V(InstructionGap) \
104 V(Integer32ToDouble) \ 104 V(Integer32ToDouble) \
105 V(InvokeFunction) \ 105 V(InvokeFunction) \
106 V(IsConstructCallAndBranch) \ 106 V(IsConstructCallAndBranch) \
107 V(IsNilAndBranch) \ 107 V(IsNilAndBranch) \
108 V(IsObjectAndBranch) \ 108 V(IsObjectAndBranch) \
109 V(IsStringAndBranch) \ 109 V(IsStringAndBranch) \
110 V(IsSmiAndBranch) \ 110 V(IsSmiAndBranch) \
111 V(IsUndetectableAndBranch) \ 111 V(IsUndetectableAndBranch) \
112 V(StringCompareAndBranch) \
113 V(JSArrayLength) \ 112 V(JSArrayLength) \
114 V(Label) \ 113 V(Label) \
115 V(LazyBailout) \ 114 V(LazyBailout) \
116 V(LoadContextSlot) \ 115 V(LoadContextSlot) \
117 V(LoadElements) \ 116 V(LoadElements) \
118 V(LoadExternalArrayPointer) \ 117 V(LoadExternalArrayPointer) \
119 V(LoadFunctionPrototype) \ 118 V(LoadFunctionPrototype) \
120 V(LoadGlobalCell) \ 119 V(LoadGlobalCell) \
121 V(LoadGlobalGeneric) \ 120 V(LoadGlobalGeneric) \
122 V(LoadKeyedFastElement) \ 121 V(LoadKeyedFastElement) \
123 V(LoadKeyedFastDoubleElement) \ 122 V(LoadKeyedFastDoubleElement) \
124 V(LoadKeyedGeneric) \ 123 V(LoadKeyedGeneric) \
125 V(LoadKeyedSpecializedArrayElement) \ 124 V(LoadKeyedSpecializedArrayElement) \
126 V(LoadNamedField) \ 125 V(LoadNamedField) \
127 V(LoadNamedFieldPolymorphic) \ 126 V(LoadNamedFieldPolymorphic) \
128 V(LoadNamedGeneric) \ 127 V(LoadNamedGeneric) \
129 V(MathFloorOfDiv) \ 128 V(MathFloorOfDiv) \
129 V(MathMinMax) \
130 V(MathPowHalf) \ 130 V(MathPowHalf) \
131 V(ModI) \ 131 V(ModI) \
132 V(MulI) \ 132 V(MulI) \
133 V(NumberTagD) \ 133 V(NumberTagD) \
134 V(NumberTagI) \ 134 V(NumberTagI) \
135 V(NumberUntagD) \ 135 V(NumberUntagD) \
136 V(ObjectLiteral) \ 136 V(ObjectLiteral) \
137 V(OsrEntry) \ 137 V(OsrEntry) \
138 V(OuterContext) \ 138 V(OuterContext) \
139 V(Parameter) \ 139 V(Parameter) \
(...skipping 11 matching lines...) Expand all
151 V(StoreGlobalGeneric) \ 151 V(StoreGlobalGeneric) \
152 V(StoreKeyedFastDoubleElement) \ 152 V(StoreKeyedFastDoubleElement) \
153 V(StoreKeyedFastElement) \ 153 V(StoreKeyedFastElement) \
154 V(StoreKeyedGeneric) \ 154 V(StoreKeyedGeneric) \
155 V(StoreKeyedSpecializedArrayElement) \ 155 V(StoreKeyedSpecializedArrayElement) \
156 V(StoreNamedField) \ 156 V(StoreNamedField) \
157 V(StoreNamedGeneric) \ 157 V(StoreNamedGeneric) \
158 V(StringAdd) \ 158 V(StringAdd) \
159 V(StringCharCodeAt) \ 159 V(StringCharCodeAt) \
160 V(StringCharFromCode) \ 160 V(StringCharFromCode) \
161 V(StringCompareAndBranch) \
161 V(StringLength) \ 162 V(StringLength) \
162 V(SubI) \ 163 V(SubI) \
163 V(TaggedToI) \ 164 V(TaggedToI) \
164 V(ThisFunction) \ 165 V(ThisFunction) \
165 V(Throw) \ 166 V(Throw) \
166 V(ToFastProperties) \ 167 V(ToFastProperties) \
167 V(TransitionElementsKind) \ 168 V(TransitionElementsKind) \
168 V(Typeof) \ 169 V(Typeof) \
169 V(TypeofIsAndBranch) \ 170 V(TypeofIsAndBranch) \
170 V(UnaryMathOperation) \ 171 V(UnaryMathOperation) \
(...skipping 910 matching lines...) Expand 10 before | Expand all | Expand 10 after
1081 LAddI(LOperand* left, LOperand* right) { 1082 LAddI(LOperand* left, LOperand* right) {
1082 inputs_[0] = left; 1083 inputs_[0] = left;
1083 inputs_[1] = right; 1084 inputs_[1] = right;
1084 } 1085 }
1085 1086
1086 DECLARE_CONCRETE_INSTRUCTION(AddI, "add-i") 1087 DECLARE_CONCRETE_INSTRUCTION(AddI, "add-i")
1087 DECLARE_HYDROGEN_ACCESSOR(Add) 1088 DECLARE_HYDROGEN_ACCESSOR(Add)
1088 }; 1089 };
1089 1090
1090 1091
1092 class LMathMinMax: public LTemplateInstruction<1, 2, 0> {
1093 public:
1094 LMathMinMax(LOperand* left, LOperand* right) {
1095 inputs_[0] = left;
1096 inputs_[1] = right;
1097 }
1098
1099 DECLARE_CONCRETE_INSTRUCTION(MathMinMax, "min-max")
1100 DECLARE_HYDROGEN_ACCESSOR(MathMinMax)
1101 };
1102
1103
1091 class LPower: public LTemplateInstruction<1, 2, 0> { 1104 class LPower: public LTemplateInstruction<1, 2, 0> {
1092 public: 1105 public:
1093 LPower(LOperand* left, LOperand* right) { 1106 LPower(LOperand* left, LOperand* right) {
1094 inputs_[0] = left; 1107 inputs_[0] = left;
1095 inputs_[1] = right; 1108 inputs_[1] = right;
1096 } 1109 }
1097 1110
1098 DECLARE_CONCRETE_INSTRUCTION(Power, "power") 1111 DECLARE_CONCRETE_INSTRUCTION(Power, "power")
1099 DECLARE_HYDROGEN_ACCESSOR(Power) 1112 DECLARE_HYDROGEN_ACCESSOR(Power)
1100 }; 1113 };
(...skipping 1404 matching lines...) Expand 10 before | Expand all | Expand 10 after
2505 2518
2506 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2519 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2507 }; 2520 };
2508 2521
2509 #undef DECLARE_HYDROGEN_ACCESSOR 2522 #undef DECLARE_HYDROGEN_ACCESSOR
2510 #undef DECLARE_CONCRETE_INSTRUCTION 2523 #undef DECLARE_CONCRETE_INSTRUCTION
2511 2524
2512 } } // namespace v8::internal 2525 } } // namespace v8::internal
2513 2526
2514 #endif // V8_IA32_LITHIUM_IA32_H_ 2527 #endif // V8_IA32_LITHIUM_IA32_H_
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698