New Guest mode avatar on the start screen

New Guest mode avatar on the start screen

BUG=140417
TEST=units, out/Debug/chrome --disable-seccomp-sandbox --parallel-auth --login-manager --login-profile=user --log-level=0 --enable-logging=stderr --no-first-run --user-data-dir=/tmp/user --in-chrome-auth --scroll-pixels=3 --enable-smooth-scrolling --force-compositing-mode --force-device-scale-factor=2 --load-2x-resources

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150937

[glotov, 2012-08-03 14:37:21]

Seems chrome/browser/resources/chromeos/login/user_pod_row.js
b/chrome/browser/resources/chromeos/login/user_pod_row.js must be modified as
well. I tried to mimic -webkit-image-set, but it did not work. Nikita, could you
ask about what should be used here?

[Nikita (slow), 2012-08-03 14:46:26]

+Peter, how should we detect in JS code dpi?

 updateUserImage: function() {
      this.imageElement.src = this.isGuest ?
          'chrome://theme/IDR_LOGIN_GUEST' :
          'chrome://userimage/' + this.user.username +
              '?id=' + (new Date()).getTime() + '&animated';
    },

http://code.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/resources/ch...

[Nikita (slow), 2012-08-03 16:31:51]

Please don't commit this CL yet, still finalizing this asset.

[pkotwicz, 2012-08-03 16:56:36]

In most places in the code, chrome://theme is automatically converted to a
webkit-image-set by this script:
http://code.google.com/searchframe#OAMlx_jo-ck/src/tools/grit/grit/gather/chr...
The script will not handle the case above though.
var image_without_scale_factor = this.isGuest ? ....
this.imageElement.backgroundImage = "-webkit-image-set(url(" +
image_without_scale_factor + "@1x), 1, url(" + image_without_scale_factor +
"@2x), 2)"

[Ivan Korotkov, 2012-08-03 17:04:53]

This looks awful... What about 'src = ... + "@" + window.devicePixelRatio +
"x"'?

[pkotwicz, 2012-08-03 17:27:30]

That should work as well

[Nikita (slow), 2012-08-06 14:01:46]

lgtm for these assets

[commit-bot: I haz the power, 2012-08-06 21:51:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/glotov@chromium.org/10829166/8003

[commit-bot: I haz the power, 2012-08-06 21:51:20]

Presubmit check for 10829166-8003 failed and returned exit status 1.

Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1257, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1105, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1022, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 19, in CheckChangeOnCommit
  File "<string>", line 44, in _CommonChecks
  File
"/b/commit-queue/workdir/chromium/chrome/app/theme/../../../ui/resources/resource_check/resource_scale_factors.py",
line 93, in RunChecks
    width, height = ImageSize(image_path)
  File
"/b/commit-queue/workdir/chromium/chrome/app/theme/../../../ui/resources/resource_check/resource_scale_factors.py",
line 47, in ImageSize
    assert data[:8] == '\x89PNG\r\n\x1A\n' and data[12:16] == 'IHDR'
AssertionError