Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: chrome/browser/ui/webui/about_ui.cc

Issue 10829156: Linux: add BPF sandbox status in about:sandbox (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | content/common/sandbox_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/about_ui.cc
diff --git a/chrome/browser/ui/webui/about_ui.cc b/chrome/browser/ui/webui/about_ui.cc
index e4a207121b25bf5454da5cef012e04269b836d2d..6897cba2a6f8980fe6a20eac64926a9571b86182 100644
--- a/chrome/browser/ui/webui/about_ui.cc
+++ b/chrome/browser/ui/webui/about_ui.cc
@@ -975,14 +975,19 @@ std::string AboutSandbox() {
status & content::kSandboxLinuxPIDNS);
AboutSandboxRow(&data, "  ", IDS_ABOUT_SANDBOX_NET_NAMESPACES,
status & content::kSandboxLinuxNetNS);
- AboutSandboxRow(&data, "", IDS_ABOUT_SANDBOX_SECCOMP_SANDBOX,
- status & content::kSandboxLinuxSeccomp);
+ AboutSandboxRow(&data, "", IDS_ABOUT_SANDBOX_SECCOMP_LEGACY_SANDBOX,
+ status & content::kSandboxLinuxSeccompLegacy);
+ AboutSandboxRow(&data, "", IDS_ABOUT_SANDBOX_SECCOMP_BPF_SANDBOX,
+ status & content::kSandboxLinuxSeccompBpf);
data.append("</table>");
+ // We do not consider the seccomp-bpf status here as the renderers
+ // policy is weak at the moment.
+ // TODO(jln): fix when whe have better renderer policies.
bool good = ((status & content::kSandboxLinuxSUID) &&
(status & content::kSandboxLinuxPIDNS)) ||
- (status & content::kSandboxLinuxSeccomp);
+ (status & content::kSandboxLinuxSeccompLegacy);
if (good) {
data.append("<p style=\"color: green\">");
data.append(l10n_util::GetStringUTF8(IDS_ABOUT_SANDBOX_OK));
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | content/common/sandbox_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698