Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: webkit/media/buffered_data_source.cc

Issue 10829155: Report that we're no longer downloading when the resource loader has finished loading. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: add tests Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/media/buffered_data_source_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/buffered_data_source.cc
diff --git a/webkit/media/buffered_data_source.cc b/webkit/media/buffered_data_source.cc
index abfc5d6e97991660254ff890b20153ef3ff0dc2d..ef010033af4b9bf6f242e8279c8b5e09e678b733 100644
--- a/webkit/media/buffered_data_source.cc
+++ b/webkit/media/buffered_data_source.cc
@@ -457,17 +457,16 @@ void BufferedDataSource::LoadingStateChangedCallback(
is_downloading_data = true;
break;
case BufferedResourceLoader::kLoadingDeferred:
+ case BufferedResourceLoader::kLoadingFinished:
is_downloading_data = false;
break;
// TODO(scherkus): we don't signal network activity changes when loads
- // complete or fail to preserve existing behaviour when deferring is
- // toggled, however we considering changing DownloadingCB to also
- // propagate loading state. For example there isn't any signal today
- // to notify the client that loading has failed/finished (we only get
- // errors on subsequent reads).
+ // fail to preserve existing behaviour when deferring is toggled, however
+ // we should consider changing DownloadingCB to also propagate loading
+ // state. For example there isn't any signal today to notify the client that
+ // loading has failed (we only get errors on subsequent reads).
case BufferedResourceLoader::kLoadingFailed:
- case BufferedResourceLoader::kLoadingFinished:
return;
}
« no previous file with comments | « no previous file | webkit/media/buffered_data_source_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698