Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 10829155: Report that we're no longer downloading when the resource loader has finished loading. (Closed)

Created:
8 years, 4 months ago by scherkus (not reviewing)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Report that we're no longer downloading when the resource loader has finished loading. The end result is that we now go back to NETWORK_IDLE after the resource has loaded. BUG=139511 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149879

Patch Set 1 #

Patch Set 2 : fix english #

Patch Set 3 : add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M webkit/media/buffered_data_source.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M webkit/media/buffered_data_source_unittest.cc View 1 2 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scherkus (not reviewing)
working on a test
8 years, 4 months ago (2012-08-02 23:39:06 UTC) #1
scherkus (not reviewing)
now with tests still investigating whether a layout test makes sense
8 years, 4 months ago (2012-08-03 00:48:46 UTC) #2
scherkus (not reviewing)
layout test: https://bugs.webkit.org/show_bug.cgi?id=93052
8 years, 4 months ago (2012-08-03 01:02:26 UTC) #3
Ami GONE FROM CHROMIUM
lgtm
8 years, 4 months ago (2012-08-03 04:27:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/10829155/3
8 years, 4 months ago (2012-08-03 16:42:01 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-03 18:47:13 UTC) #6
Change committed as 149879

Powered by Google App Engine
This is Rietveld 408576698