Issue 10829149: Extensions Docs Server: preview.py fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829149: Extensions Docs Server: preview.py fixes (Closed)

Created:
8 years, 4 months ago by cduvall

Modified:
8 years, 4 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Extensions Docs Server: preview.py fixes preview.py now runs build_server.py before running and cleans itself up afterwards. BUG=140308 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149683

Patch Set 1 : #

Total comments: 2

Patch Set 2 : comment #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/common/extensions/docs/server2/preview.py	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm https://chromiumcodereview.appspot.com/10829149/diff/2001/chrome/common/extensions/docs/server2/preview.py File chrome/common/extensions/docs/server2/preview.py (right): https://chromiumcodereview.appspot.com/10829149/diff/2001/chrome/common/extensions/docs/server2/preview.py#newcode23 chrome/common/extensions/docs/server2/preview.py:23: build_server.main() comment plz

8 years, 4 months ago (2012-08-02 19:49:07 UTC) #2

cduvall

8 years, 4 months ago (2012-08-02 19:52:08 UTC) #3

https://chromiumcodereview.appspot.com/10829149/diff/2001/chrome/common/exten...
File chrome/common/extensions/docs/server2/preview.py (right):

https://chromiumcodereview.appspot.com/10829149/diff/2001/chrome/common/exten...
chrome/common/extensions/docs/server2/preview.py:23: build_server.main()
On 2012/08/02 19:49:07, kalman wrote:
> comment plz

Done.

Expand Messages | Collapse Messages