Add parsers for Drive v2 Change/ChangeList/Parents

Add parsers for Drive v2 Change/ChangeList/Parents

Parent means a folder containing a file in Drive v2 API.
If a file does not contain any reference to its parent, it should be
interpreted as the file is under the root directory.
Changed existing unit test for checking the case that parent is missing.

BUG=chromium:127728
TEST=unit_tests --gtest_filter="DriveAPIParserTest.*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149768

[kochi, 2012-08-02 09:16:15]

Hi Satoru,

Could you review this CL?
Thanks,

http://codereview.chromium.org/10829139/diff/4001/chrome/test/data/chromeos/d...
File chrome/test/data/chromeos/drive/filelist.json (left):

http://codereview.chromium.org/10829139/diff/4001/chrome/test/data/chromeos/d...
chrome/test/data/chromeos/drive/filelist.json:86: ],
Some file may not contain parents field.
In that case we assume the file is under the root directory.

[satorux1, 2012-08-02 16:41:51]

http://codereview.chromium.org/10829139/diff/4001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/drive_api_parser.h (right):

http://codereview.chromium.org/10829139/diff/4001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/drive_api_parser.h:412: class ChangeResource {
class comment is missing. what is a change resource?

http://codereview.chromium.org/10829139/diff/4001/chrome/test/data/chromeos/d...
File chrome/test/data/chromeos/drive/filelist.json (left):

http://codereview.chromium.org/10829139/diff/4001/chrome/test/data/chromeos/d...
chrome/test/data/chromeos/drive/filelist.json:86: ],
On 2012/08/02 09:16:15, Takayoshi Kochi wrote:
> Some file may not contain parents field.
> In that case we assume the file is under the root directory.

Please add some comment on this in the patch description.

[kochi, 2012-08-02 17:16:47]

Thanks for the review.
Comments and description updated.

http://chromiumcodereview.appspot.com/10829139/diff/4001/chrome/browser/chrom...
File chrome/browser/chromeos/gdata/drive_api_parser.h (right):

http://chromiumcodereview.appspot.com/10829139/diff/4001/chrome/browser/chrom...
chrome/browser/chromeos/gdata/drive_api_parser.h:412: class ChangeResource {
On 2012/08/02 16:41:51, satorux1 wrote:
> class comment is missing. what is a change resource?

Done.

http://chromiumcodereview.appspot.com/10829139/diff/4001/chrome/test/data/chr...
File chrome/test/data/chromeos/drive/filelist.json (left):

http://chromiumcodereview.appspot.com/10829139/diff/4001/chrome/test/data/chr...
chrome/test/data/chromeos/drive/filelist.json:86: ],
On 2012/08/02 16:41:51, satorux1 wrote:
> On 2012/08/02 09:16:15, Takayoshi Kochi wrote:
> > Some file may not contain parents field.
> > In that case we assume the file is under the root directory.
> 
> Please add some comment on this in the patch description.

Done.

[satorux1, 2012-08-02 19:39:18]

LGTM with a nit

http://codereview.chromium.org/10829139/diff/5002/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/drive_api_parser.h (right):

http://codereview.chromium.org/10829139/diff/5002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/drive_api_parser.h:429: int64 change_id() const {
return change_id_; }
please add a blank line between accessors.

[kochi, 2012-08-03 01:01:53]

Thanks.
Comment addressed and fixed uninitialized member
(valgrind check).
I'll be submitting soon.