Refactoring NTP5: new implementation of TilePage and MostVisitedPage (which now inherits from Thumb…

chrome/browser/resources/ntp_search/new_tab.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview New tab page
  * This is the main code for the new tab page used by touch-enabled Chrome
  * browsers.  For now this is still a prototype.
  */
 
@@ skipping 69 matching lines @@
   function NewTabView() {
     var pageSwitcherStart = null;
     var pageSwitcherEnd = null;
     if (loadTimeData.getValue('showApps')) {
       pageSwitcherStart = getRequiredElement('page-switcher-start');
       pageSwitcherEnd = getRequiredElement('page-switcher-end');
     }
     this.initialize(getRequiredElement('page-list'),
                     getRequiredElement('dot-list'),
                     getRequiredElement('card-slider-frame'),
                     getRequiredElement('trash'),

[jeremycho_google, 2012/08/02 00:19:11]

Add a TODO for removing these non-1993 features?

[pedrosimonetti2, 2012/08/03 18:14:12]

Done.

                     pageSwitcherStart, pageSwitcherEnd);
   }
 
   NewTabView.prototype = {
     __proto__: ntp.PageListView.prototype,
 
     /** @inheritDoc */
     appendTilePage: function(page, title, titleIsEditable, opt_refNode) {
       ntp.PageListView.prototype.appendTilePage.apply(this, arguments);
 
@@ skipping 80 matching lines @@
       // The anchor node won't be updated until updateLogin is called so don't
       // show the bubble yet.
       shouldShowLoginBubble = true;
     }
 
     var loginContainer = getRequiredElement('login-container');
     loginContainer.addEventListener('click', showSyncLoginUI);
     chrome.send('initializeSyncLogin');
 
     doWhenAllSectionsReady(function() {
+
+      // TODO(xci) new!
+      // TODO(pedrosimonetti): find a better place to put this code. Every,
+      // card needs to call layout the first time is shown.
+      newTabView.cardSlider.currentCardValue.layout_();
+
       // Tell the slider about the pages.
       newTabView.updateSliderCards();
       // Mark the current page.
       newTabView.cardSlider.currentCardValue.navigationDot.classList.add(
           'selected');
 
       if (loadTimeData.valueExists('serverpromo')) {
         var promo = loadTimeData.getString('serverpromo');
         var tags = ['IMG'];
         var attrs = {
@@ skipping 237 matching lines @@
 
   function setMostVisitedPages(data, hasBlacklistedUrls) {
     newTabView.mostVisitedPage.data = data;
     cr.dispatchSimpleEvent(document, 'sectionready', true, true);
   }
 
   function setSuggestionsPages(data, hasBlacklistedUrls) {
     newTabView.suggestionsPage.data = data;
   }
 
+  function getThumbnailUrl(url) {
+    return 'chrome://thumb/' + url;
+  }
+
   /**
    * Set the dominant color for a node. This will be called in response to
    * getFaviconDominantColor. The node represented by |id| better have a setter
    * for stripeColor.
    * @param {string} id The ID of a node.
    * @param {string} color The color represented as a CSS string.
    */
   function setStripeColor(id, color) {
     var node = $(id);
     if (node)
@@ skipping 118 matching lines @@
     onLoad: onLoad,
     leaveRearrangeMode: leaveRearrangeMode,
     NtpFollowAction: NtpFollowAction,
     saveAppPageName: saveAppPageName,
     setAppToBeHighlighted: setAppToBeHighlighted,
     setBookmarkBarAttached: setBookmarkBarAttached,
     setForeignSessions: setForeignSessions,
     setMostVisitedPages: setMostVisitedPages,
     setSuggestionsPages: setSuggestionsPages,
     setRecentlyClosedTabs: setRecentlyClosedTabs,
+    getThumbnailUrl: getThumbnailUrl,

[jeremycho_google, 2012/08/02 00:19:11]

alphabetize

[pedrosimonetti2, 2012/08/03 18:14:12]

Done.

     setStripeColor: setStripeColor,
     showNotification: showNotification,
     themeChanged: themeChanged,
     updateLogin: updateLogin
   };
 });
 
 document.addEventListener('DOMContentLoaded', ntp.onLoad);
 
 var toCssPx = cr.ui.toCssPx;