Issue 10829130: gdata: Remove NotifyDirectoryChanged() and NotifyDocumentFeedFetched()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829130: gdata: Remove NotifyDirectoryChanged() and NotifyDocumentFeedFetched() (Closed)

Created:
8 years, 4 months ago by satorux1

Modified:
8 years, 4 months ago

Reviewers:
achuithb

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Remove NotifyDirectoryChanged() and NotifyDocumentFeedFetched() These are just calling FOR_EACH_OBSERVER. In the past, these Notify* functions were used to post a task to UI thread, to notify observers on UI thread, but we no longer need this indirection. BUG=138268 TEST=none; this does not change behaviors Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149571

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -31 lines)			Patch
	M	chrome/browser/chromeos/gdata/gdata_file_system.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View		11 chunks	+17 lines, -27 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/10829130/1

8 years, 4 months ago (2012-08-02 00:11:28 UTC) #3

Change committed as 149571

Expand Messages | Collapse Messages