Archive PDF breakpad symbols for official builds.

Archive PDF breakpad symbols for official builds.

BUG=140059
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149567

[Lei Zhang, 2012-08-01 18:09:27]

I have no idea if this is right.

[Michael Moss, 2012-08-01 18:15:14]

It's right if we're actually generating those breakpad symbols. I'll
try to verify.

On Wed, Aug 1, 2012 at 11:09 AM,  <thestig@chromium.org> wrote:
> Reviewers: Michael Moss, laforge,
>
> Message:
> I have no idea if this is right.
>
> Description:
> Archive PDF breakpad symbols for official builds.
>
> BUG=140059
> TEST=none
>
> Please review this at https://chromiumcodereview.appspot.com/10829126/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>   M     chrome/tools/build/linux/FILES.cfg
>
>
> Index: chrome/tools/build/linux/FILES.cfg
> ===================================================================
> --- chrome/tools/build/linux/FILES.cfg  (revision 149385)
> +++ chrome/tools/build/linux/FILES.cfg  (working copy)
> @@ -177,6 +177,18 @@
>      'archive': 'breakpad-info.zip',
>    },
>    {
> +    'filename': 'libpdf.so.breakpad.ia32',
> +    'arch': ['32bit'],
> +    'buildtype': ['official'],
> +    'archive': 'breakpad-info.zip',
> +  },
> +  {
> +    'filename': 'libpdf.so.breakpad.x64',
> +    'arch': ['64bit'],
> +    'buildtype': ['official'],
> +    'archive': 'breakpad-info.zip',
> +  },
> +  {
>      'filename': 'libremoting_host_plugin.ia32.so.breakpad.ia32',
>      'arch': ['32bit'],
>      'buildtype': ['official'],
>
>

[Lei Zhang, 2012-08-01 18:19:39]

On 2012/08/01 18:15:14, Michael Moss wrote:
> It's right if we're actually generating those breakpad symbols. I'll
> try to verify.

We are probably not. We need a target like linux_symbols for pdf.

[Lei Zhang, 2012-08-01 19:09:52]

On 2012/08/01 18:19:39, Lei Zhang wrote:
> We are probably not. We need a target like linux_symbols for pdf.

Send out a CL for review to add a pdf linux symbols target. Will ping again once
that's committed.

[Lei Zhang, 2012-08-02 01:03:05]

I tested patch set 2 locally and it generates out/Release/libpdf.so.breakpad.x64
for me.

[Michael Moss, 2012-08-02 01:13:07]

LGTM

[commit-bot: I haz the power, 2012-08-02 01:15:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/10829126/5001

[commit-bot: I haz the power, 2012-08-02 02:55:38]

Change committed as 149567