Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 10829121: Fix file type filter in Chrome OS Open/Save dialogs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/file_manager/js/file_manager.js
diff --git a/chrome/browser/resources/file_manager/js/file_manager.js b/chrome/browser/resources/file_manager/js/file_manager.js
index 6657ff1ebd9ceec457dddec92e2cc08a9203966f..7c5dcea6b22b07035c50e8349e12185e2ae11aa3 100644
--- a/chrome/browser/resources/file_manager/js/file_manager.js
+++ b/chrome/browser/resources/file_manager/js/file_manager.js
@@ -1425,14 +1425,15 @@ FileManager.prototype = {
FileManager.prototype.updateFileTypeFilter_ = function() {
this.directoryModel_.removeFilter('fileType');
var selectedIndex = Number(this.fileTypeSelector_.selectedIndex);
- if (selectedIndex < 1) // 'All files' or nothing selected.
- return;
- var regexp = new RegExp('.*(' +
- this.fileTypes_[selectedIndex - 1].extensions.join('|') + ')$', 'i');
- function filter(entry) {
- return entry.isDirectory || regexp.test(entry.name);
+ if (selectedIndex >= 1) { // Specific filter selected.
+ var regexp = new RegExp('.*(' +
+ this.fileTypes_[selectedIndex - 1].extensions.join('|') + ')$', 'i');
+ function filter(entry) {
+ return entry.isDirectory || regexp.test(entry.name);
+ }
+ this.directoryModel_.addFilter('fileType', filter);
}
- this.directoryModel_.addFilter('fileType', filter);
+ this.directoryModel_.rescan();
};
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698