Issue 10829118: gdata: Move GDataWapiFeedParser to a set of new files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829118: gdata: Move GDataWapiFeedParser to a set of new files (Closed)

Created:
8 years, 4 months ago by satorux1

Modified:
8 years, 4 months ago

Reviewers:
achuithb

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Move GDataWapiFeedParser to a set of new files This change reduces ~400 lines from gdata_file_system.cc BUG=130669 TEST=none; just move code around. should not change the behaviors TBR=ben@chromium.org for chrome_browser.gypi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149462

Patch Set 1 #

Patch Set 2 : fix clang build #

Patch Set 3 : fix clang build for sure... #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+447 lines, -391 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View		3 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View	1	4 chunks	+0 lines, -386 lines	0 comments	Download
A	chrome/browser/chromeos/gdata/gdata_wapi_feed_processor.h	View	1 2	1 chunk	+111 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/gdata/gdata_wapi_feed_processor.cc	View	1 2	1 chunk	+331 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Add TBR=ben@chromium.org  for chrome_browser.gypi

Expand Messages | Collapse Messages