Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 10829117: contacts: Add FakeContactDatabase. (Closed)

Created:
8 years, 4 months ago by Daniel Erat
Modified:
8 years, 4 months ago
Reviewers:
satorux1
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

contacts: Add FakeContactDatabase. This class provides a fake, memory-backed implementation of ContactDatabaseInterface. BUG=128805 TEST=none TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149544

Patch Set 1 #

Patch Set 2 : add an OVERRIDE #

Patch Set 3 : update chrome_tests.gypi #

Patch Set 4 : whoops, diff against the correct branch #

Patch Set 5 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -0 lines) Patch
A chrome/browser/chromeos/contacts/fake_contact_database.h View 1 1 chunk +58 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/contacts/fake_contact_database.cc View 1 chunk +65 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Daniel Erat
8 years, 4 months ago (2012-08-01 04:12:35 UTC) #1
satorux1
LGTM
8 years, 4 months ago (2012-08-01 20:13:23 UTC) #2
Daniel Erat
TBR ben for chrome_tests.gypi
8 years, 4 months ago (2012-08-01 22:56:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10829117/5002
8 years, 4 months ago (2012-08-01 22:57:00 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 00:39:11 UTC) #5
Change committed as 149544

Powered by Google App Engine
This is Rietveld 408576698