Issue 10829114: Http cache: Always revalidate PUT and DELETE requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829114: Http cache: Always revalidate PUT and DELETE requests. (Closed)

Created:
8 years, 4 months ago by rvargas (doing something else)

Modified:
8 years, 4 months ago

Reviewers:
gavinp

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, gavinp+disk_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Http cache: Always revalidate PUT and DELETE requests. BUG=136320 TEST=net_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149643

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	net/http/http_cache_transaction.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	net/http/http_cache_unittest.cc	View	1	2 chunks	+2 lines, -6 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

gavinp

8 years, 4 months ago (2012-08-02 14:41:15 UTC) #2

lgtm

http://codereview.chromium.org/10829114/diff/6002/net/http/http_cache_unittes...
File net/http/http_cache_unittest.cc (left):

http://codereview.chromium.org/10829114/diff/6002/net/http/http_cache_unittes...
net/http/http_cache_unittest.cc:2359: transaction.method = "GET";
ha!

Expand Messages | Collapse Messages