Issue 10829113: Fix CacheStats histogram name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829113: Fix CacheStats histogram name. (Closed)

Created:
8 years, 4 months ago by tburkard

Modified:
8 years, 4 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix CacheStats histogram name. R=jar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149339

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/net/cache_stats.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

8 years, 4 months ago (2012-08-01 01:00:51 UTC) #2

You're using a lot of histograms here.  Please be conscious of the user
footprint you're taking up.  It costs about 12bytes per bucket per histogram,
plus about 4 times the size of the histogram names.  I'd bet your around 30K for
the histograms I can see.

Consider pulling out these histograms when you realize your granularity (100
buckets) is too high to add value.

LGTM

Expand Messages | Collapse Messages