Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 10829104: Android: upstream @DisabledTest annotation for instrumentation tests. (Closed)

Created:
8 years, 4 months ago by bulach
Modified:
8 years, 4 months ago
Reviewers:
Ted C, nilesh
CC:
chromium-reviews, joi+watch-content_chromium.org, erikwright (departed), darin-cc_chromium.org, jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Android: upstream @DisabledTest annotation for instrumentation tests. This annotation is used to disable specific instrumentation tests. While at it, disable the failing testBaseStartup. BUG=139365, 139870 TEST=Android FYI tester bot is green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
A + base/android/javatests/src/org/chromium/base/test/DisabledTest.java View 2 chunks +7 lines, -6 lines 0 comments Download
M content/shell/android/javatests/src/org/chromium/content_shell/ContentShellUrlTest.java View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
bulach
8 years, 4 months ago (2012-07-31 20:16:13 UTC) #1
Ted C
lgtm
8 years, 4 months ago (2012-07-31 20:17:03 UTC) #2
nilesh
On 2012/07/31 20:17:03, Ted C wrote: > lgtm LGTM Bug filed: http://code.google.com/p/chromium/issues/detail?id=139870
8 years, 4 months ago (2012-07-31 20:40:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/10829104/1
8 years, 4 months ago (2012-08-01 11:07:12 UTC) #4
bulach
many thanks nilesh! updated the issue to point to the bug, CQing..
8 years, 4 months ago (2012-08-01 11:07:26 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 13:12:34 UTC) #6
Change committed as 149405

Powered by Google App Engine
This is Rietveld 408576698