lib/compiler/implementation/compiler.dart - Issue 10829102: Create 'unified' version of Date, with a dart2js implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/compiler.dart

Issue 10829102: Create 'unified' version of Date, with a dart2js implementation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Update comment and group external methods. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « corelib/unified/core/implementation/date.dart ('k') | lib/compiler/implementation/lib/core.dart » ('j') | lib/compiler/implementation/lib/coreimpl.dartp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/compiler.dart

diff --git a/lib/compiler/implementation/compiler.dart b/lib/compiler/implementation/compiler.dart

index abc40e3844ecb79c6f81597dd1aa5ef21c544333..ee640dc30680e342dc2d38c9aedacd3bc0162f9c 100644

--- a/lib/compiler/implementation/compiler.dart

+++ b/lib/compiler/implementation/compiler.dart

@@ -556,8 +556,12 @@ class Compiler implements DiagnosticListener {

while (!patches.isEmpty()) {

Element patchElement = patches.head;

Element originalElement = lookup(patchElement.name);

- // Getters and setters are kept inside a synthetic field.

- if (patchElement.kind === ElementKind.ABSTRACT_FIELD) {

+ if (patchElement.isAccessor()) {

+ // Skip accessors. An accessor always have an abstract field,

floitsch 2012/08/01 09:05:01 has

Anders Johnsen 2012/08/01 09:15:38 Done.

+ // representing the accessor in the lookup scope. We can then always

floitsch 2012/08/01 09:05:01 We can thus skip the accessor and just handle the

Anders Johnsen 2012/08/01 09:15:38 Done.

+ // skip accessors and just handle the abstract field.

+ } else if (patchElement.kind === ElementKind.ABSTRACT_FIELD) {

+ // Getters and setters are kept inside a synthetic field.

if (originalElement !== null &&

originalElement.kind !== ElementKind.ABSTRACT_FIELD) {

internalError("Cannot patch non-getter/setter with getter/setter",