Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/chromeos/gdata/drive_api_parser_unittest.cc

Issue 10829094: Cleanup: Use EXPECT_TRUE/FALSE instead of EXPECT_EQ. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_path.h" 5 #include "base/file_path.h"
6 #include "base/file_util.h" 6 #include "base/file_util.h"
7 #include "base/json/json_file_value_serializer.h" 7 #include "base/json/json_file_value_serializer.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/string16.h" 9 #include "base/string16.h"
10 #include "base/time.h" 10 #include "base/time.h"
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 EXPECT_TRUE(applist->Parse(*document)); 76 EXPECT_TRUE(applist->Parse(*document));
77 77
78 EXPECT_EQ("\"Jm4BaSnCWNND-noZsHINRqj4ABC/tuqRBw0lvjUdPtc_2msA1tN4XYZ\"", 78 EXPECT_EQ("\"Jm4BaSnCWNND-noZsHINRqj4ABC/tuqRBw0lvjUdPtc_2msA1tN4XYZ\"",
79 applist->etag()); 79 applist->etag());
80 IF_EXPECT_EQ(2U, applist->items().size()) { 80 IF_EXPECT_EQ(2U, applist->items().size()) {
81 // Check Drive app 1 81 // Check Drive app 1
82 const AppResource& app1 = *applist->items()[0]; 82 const AppResource& app1 = *applist->items()[0];
83 EXPECT_EQ("123456788192", app1.id()); 83 EXPECT_EQ("123456788192", app1.id());
84 EXPECT_EQ("Drive app 1", app1.name()); 84 EXPECT_EQ("Drive app 1", app1.name());
85 EXPECT_EQ("", app1.object_type()); 85 EXPECT_EQ("", app1.object_type());
86 EXPECT_EQ(true, app1.supports_create()); 86 EXPECT_TRUE(app1.supports_create());
87 EXPECT_EQ(true, app1.supports_import()); 87 EXPECT_TRUE(app1.supports_import());
88 EXPECT_EQ(true, app1.is_installed()); 88 EXPECT_TRUE(app1.is_installed());
89 EXPECT_EQ(false, app1.is_authorized()); 89 EXPECT_FALSE(app1.is_authorized());
90 EXPECT_EQ("https://chrome.google.com/webstore/detail/" 90 EXPECT_EQ("https://chrome.google.com/webstore/detail/"
91 "abcdefghabcdefghabcdefghabcdefgh", 91 "abcdefghabcdefghabcdefghabcdefgh",
92 app1.product_url().spec()); 92 app1.product_url().spec());
93 93
94 IF_EXPECT_EQ(1U, app1.primary_mimetypes().size()) { 94 IF_EXPECT_EQ(1U, app1.primary_mimetypes().size()) {
95 EXPECT_EQ("application/vnd.google-apps.drive-sdk.123456788192", 95 EXPECT_EQ("application/vnd.google-apps.drive-sdk.123456788192",
96 *app1.primary_mimetypes()[0]); 96 *app1.primary_mimetypes()[0]);
97 } 97 }
98 98
99 IF_EXPECT_EQ(2U, app1.secondary_mimetypes().size()) { 99 IF_EXPECT_EQ(2U, app1.secondary_mimetypes().size()) {
(...skipping 18 matching lines...) Expand all
118 EXPECT_EQ(DriveAppIcon::SHARED_DOCUMENT, icon6.category()); 118 EXPECT_EQ(DriveAppIcon::SHARED_DOCUMENT, icon6.category());
119 EXPECT_EQ(16, icon6.icon_side_length()); 119 EXPECT_EQ(16, icon6.icon_side_length());
120 EXPECT_EQ("http://www.example.com/ds16.png", icon6.icon_url().spec()); 120 EXPECT_EQ("http://www.example.com/ds16.png", icon6.icon_url().spec());
121 } 121 }
122 122
123 // Check Drive app 2 123 // Check Drive app 2
124 const AppResource& app2 = *applist->items()[1]; 124 const AppResource& app2 = *applist->items()[1];
125 EXPECT_EQ("876543210000", app2.id()); 125 EXPECT_EQ("876543210000", app2.id());
126 EXPECT_EQ("Drive app 2", app2.name()); 126 EXPECT_EQ("Drive app 2", app2.name());
127 EXPECT_EQ("", app2.object_type()); 127 EXPECT_EQ("", app2.object_type());
128 EXPECT_EQ(false, app2.supports_create()); 128 EXPECT_FALSE(app2.supports_create());
129 EXPECT_EQ(false, app2.supports_import()); 129 EXPECT_FALSE(app2.supports_import());
130 EXPECT_EQ(true, app2.is_installed()); 130 EXPECT_TRUE(app2.is_installed());
131 EXPECT_EQ(false, app2.is_authorized()); 131 EXPECT_FALSE(app2.is_authorized());
132 EXPECT_EQ("https://chrome.google.com/webstore/detail/" 132 EXPECT_EQ("https://chrome.google.com/webstore/detail/"
133 "hgfedcbahgfedcbahgfedcbahgfedcba", 133 "hgfedcbahgfedcbahgfedcbahgfedcba",
134 app2.product_url().spec()); 134 app2.product_url().spec());
135 135
136 IF_EXPECT_EQ(3U, app2.primary_mimetypes().size()) { 136 IF_EXPECT_EQ(3U, app2.primary_mimetypes().size()) {
137 EXPECT_EQ("image/jpeg", 137 EXPECT_EQ("image/jpeg",
138 *app2.primary_mimetypes()[0]); 138 *app2.primary_mimetypes()[0]);
139 EXPECT_EQ("image/png", 139 EXPECT_EQ("image/png",
140 *app2.primary_mimetypes()[1]); 140 *app2.primary_mimetypes()[1]);
141 EXPECT_EQ("application/vnd.google-apps.drive-sdk.876543210000", 141 EXPECT_EQ("application/vnd.google-apps.drive-sdk.876543210000",
142 *app2.primary_mimetypes()[2]); 142 *app2.primary_mimetypes()[2]);
143 } 143 }
144 144
145 EXPECT_EQ(0U, app2.secondary_mimetypes().size()); 145 EXPECT_EQ(0U, app2.secondary_mimetypes().size());
146 EXPECT_EQ(0U, app2.primary_file_extensions().size()); 146 EXPECT_EQ(0U, app2.primary_file_extensions().size());
147 EXPECT_EQ(0U, app2.secondary_file_extensions().size()); 147 EXPECT_EQ(0U, app2.secondary_file_extensions().size());
148 148
149 IF_EXPECT_EQ(3U, app2.icons().size()) { 149 IF_EXPECT_EQ(3U, app2.icons().size()) {
150 const DriveAppIcon& icon2 = *app2.icons()[1]; 150 const DriveAppIcon& icon2 = *app2.icons()[1];
151 EXPECT_EQ(DriveAppIcon::DOCUMENT, icon2.category()); 151 EXPECT_EQ(DriveAppIcon::DOCUMENT, icon2.category());
152 EXPECT_EQ(10, icon2.icon_side_length()); 152 EXPECT_EQ(10, icon2.icon_side_length());
153 EXPECT_EQ("http://www.example.com/d10.png", icon2.icon_url().spec()); 153 EXPECT_EQ("http://www.example.com/d10.png", icon2.icon_url().spec());
154 } 154 }
155 } 155 }
156 } 156 }
157 157
158 } // namespace gdata 158 } // namespace gdata
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698