Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 10829093: NaCl: Update revision in DEPS, r9277 -> r9317 (Closed)

Created:
8 years, 4 months ago by Mark Seaborn
Modified:
8 years, 4 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com, bradn, bsy, (google.com) Derek Schuff, halyavin, jvoung (off chromium), jvoung - send to chromium..., khimg, Karl, Mark Seaborn, Nick Bray, pasko-google - do not use, Petr Hosek, robertm
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r9277 -> r9317 * r9294 requires removing 'pylib' from DEPS. This pulls in the following Native Client changes: r9278: (kschimpf) Add tzcnt as an acceptable instruction to x86-64 validator r9279: (kschimpf) Fix macros NC_EXPECT_EQ_PRECOND and NC_EXPECT_NE_PRECOND. r9281: (kschimpf) Add tzcnt as an acceptable instruction to the x86-32 validator r9282: (mseaborn) x86-64: Remove one hard-coded numeric offset into NaClThreadContext r9283: (phosek) Check of memory mapping consistency for all supported OSes. r9284: (jvoung) Handle another case where we cannot search for bugs, from 9254. r9285: (mseaborn) Thread suspension test: Refactor how we set and check register state r9287: (khim) Handle most REX prefixes r9288: (mseaborn) Introduce #defines for the offsets of NaClThreadContext fields r9289: (dschuff) Do qemu sandboxed translator tests sequentially r9290: (kschimpf) Clean up super_cop table in Arm validator. r9291: (khim) Fix precise_64-newlib-x86_64-pnacl bot r9292: (khim) Fix precise_64-newlib-x86_64-pnacl bot - try2 r9293: (dschuff) Update archived toolchain test rev to 8851 *r9294: (bradnelson) Moving third_party/pylib/* to third_party/. r9296: (bsy) code clean up and commenting: remove printing sockaddr r9297: (ncbray) Remove a redundant dependency from a broken test r9298: (mseaborn) Add a test for the registers reported for a thread suspended in a syscall r9299: (mseaborn) Make the thread_create() syscall responsible for aligning the stack pointer r9300: (pasko) Validator refactoring: define NaClCopyInstruction() for x86/arm separately r9301: (halyavin) Update gdb revision. r9302: (khim) Fix xchg instruction. r9303: (robertm) Fix readelf and size usage in preparation for r9304: (robertm) Remove unused readelf and size binary from newlib/bin directory in the pnacl toolchain r9305: (khim) Fix small typo in ragel_tester.c r9306: (khim) Fix memory leak in enuminst r9308: (kschimpf) Fix table ext_reg_move table in ARM validator. r9309: (jvoung) Bump pnacl toolchain rev to 9299. r9311: (bradnelson) Exclude pnacl/src dir from checkdeps for now. r9312: (jvoung) Remove use of mozrunner in browser tester r9313: (robertm) Fix dangling reference to size tool in pnacl toolchain build. r9314: (mseaborn) Testing: Move register_set.h into a new tests/common directory r9315: (jvoung) Bump pnacl llvm rev to pull in byval + vararg change: r9316: (mseaborn) Remove the nacl_sys array and the "sys" instance of NaClThreadContext r9317: (mseaborn) Testing: Simplify untrusted assembly code used for saving x86 flags BUG=none TEST=nacl_integration Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149187

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M DEPS View 1 3 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
The previous try (http://codereview.chromium.org/10832070/) didn't work because it lacked "r9312: (jvoung) Remove use of mozrunner ...
8 years, 4 months ago (2012-07-31 15:25:34 UTC) #1
Nick Bray (chromium)
LGTM
8 years, 4 months ago (2012-07-31 17:43:17 UTC) #2
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 11:42:01 UTC) #3
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698