Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 10829092: Track memory consumption for decoder-internal resources (Closed)

Created:
8 years, 4 months ago by ccameron
Modified:
8 years, 4 months ago
Reviewers:
greggman
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Track memory consumption for decoder-internal resources (backbuffer et al) in addition to external resources. Don't add tracing for each allocation because they're already being traced by TRACE_BACKBUFFER_MEMORY_TOTAL (which has slightly different semantics). BUG=131650 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149253

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporate review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 10 chunks +18 lines, -14 lines 0 comments Download
M gpu/command_buffer/service/memory_tracking.h View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ccameron
8 years, 4 months ago (2012-07-31 01:11:30 UTC) #1
greggman
lgtm http://codereview.chromium.org/10829092/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): http://codereview.chromium.org/10829092/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode1831 gpu/command_buffer/service/gles2_cmd_decoder.cc:1831: size.width() * size.height() * samples * style: indent ...
8 years, 4 months ago (2012-07-31 17:35:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/10829092/5001
8 years, 4 months ago (2012-07-31 18:11:59 UTC) #3
ccameron
http://codereview.chromium.org/10829092/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): http://codereview.chromium.org/10829092/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode1831 gpu/command_buffer/service/gles2_cmd_decoder.cc:1831: size.width() * size.height() * samples * On 2012/07/31 17:35:06, ...
8 years, 4 months ago (2012-07-31 18:12:00 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 19:52:27 UTC) #5
Change committed as 149253

Powered by Google App Engine
This is Rietveld 408576698